frederik
/
libxcb
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Get rid of abstract sockets support 

Abstract sockets support is an unfixable security risk.  Get rid of it.

Signed-off-by: Demi Marie Obenour <demiobenour@gmail.com>
This commit is contained in:
Demi Marie Obenour 2025-07-29 19:20:59 -04:00
parent 6a7661f60a
commit 989b532129
2 changed files with 1 additions and 48 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
configure.ac
View File

@ -144,9 +144,6 @@ mingw*)
have_win32="yes" have_win32="yes"
lt_enable_auto_import="-Wl,--enable-auto-import" lt_enable_auto_import="-Wl,--enable-auto-import"
;; ;;
linux*)
AC_DEFINE([HAVE_ABSTRACT_SOCKETS], 1, [Define if your platform supports abstract sockets])
;;
esac esac
AC_SUBST(lt_enable_auto_import) AC_SUBST(lt_enable_auto_import)

46
src/xcb_util.c
View File

@ -242,9 +242,6 @@ static int _xcb_open_tcp(const char *host, char *protocol, const unsigned short
#ifndef _WIN32 #ifndef _WIN32
static int _xcb_open_unix(char *protocol, const char *file); static int _xcb_open_unix(char *protocol, const char *file);
#endif /* !WIN32 */ #endif /* !WIN32 */
#ifdef HAVE_ABSTRACT_SOCKETS
static int _xcb_open_abstract(char *protocol, const char *file, size_t filelen);
#endif
static int _xcb_open(const char *host, char *protocol, const int display) static int _xcb_open(const char *host, char *protocol, const int display)
{ {
@ -257,7 +254,6 @@ static int _xcb_open(const char *host, char *protocol, const int display)
const char *base = unix_base; const char *base = unix_base;
size_t filelen; size_t filelen;
char *file = NULL; char *file = NULL;
int actual_filelen;
#ifndef _WIN32 #ifndef _WIN32
if (protocol && strcmp("unix", protocol) == 0 && host && host[0] == '/') { if (protocol && strcmp("unix", protocol) == 0 && host && host[0] == '/') {
@ -269,7 +265,6 @@ static int _xcb_open(const char *host, char *protocol, const int display)
if (file == NULL) if (file == NULL)
return -1; return -1;
memcpy(file, host, filelen); memcpy(file, host, filelen);
actual_filelen = (int)(filelen - 1);
} else { } else {
#endif #endif
/* If protocol or host is "unix", fall through to Unix socket code below */ /* If protocol or host is "unix", fall through to Unix socket code below */
@ -305,23 +300,11 @@ static int _xcb_open(const char *host, char *protocol, const int display)
return -1; return -1;
/* display specifies Unix socket */ /* display specifies Unix socket */
actual_filelen = snprintf(file, filelen, "%s%d", base, display); if (snprintf(file, filelen, "%s%d", base, display) < 0)
if(actual_filelen < 0)
{ {
free(file); free(file);
return -1; return -1;
} }
/* snprintf may truncate the file */
filelen = MIN(actual_filelen, filelen - 1);
#ifdef HAVE_ABSTRACT_SOCKETS
fd = _xcb_open_abstract(protocol, file, filelen);
if (fd >= 0 || (errno != ENOENT && errno != ECONNREFUSED))
{
free(file);
return fd;
}
#endif
} }
fd = _xcb_open_unix(protocol, file); fd = _xcb_open_unix(protocol, file);
free(file); free(file);
@ -492,33 +475,6 @@ static int _xcb_open_unix(char *protocol, const char *file)
} }
#endif /* !_WIN32 */ #endif /* !_WIN32 */
#ifdef HAVE_ABSTRACT_SOCKETS
static int _xcb_open_abstract(char *protocol, const char *file, size_t filelen)
{
int fd;
struct sockaddr_un addr = {0};
socklen_t namelen;
if (protocol && strcmp("unix",protocol))
return -1;
strcpy(addr.sun_path + 1, file);
addr.sun_family = AF_UNIX;
namelen = offsetof(struct sockaddr_un, sun_path) + 1 + filelen;
#ifdef HAVE_SOCKADDR_SUN_LEN
addr.sun_len = 1 + filelen;
#endif
fd = _xcb_socket(AF_UNIX, SOCK_STREAM, 0);
if (fd == -1)
return -1;
if (connect(fd, (struct sockaddr *) &addr, namelen) == -1) {
close(fd);
return -1;
}
return fd;
}
#endif
xcb_connection_t *xcb_connect(const char *displayname, int *screenp) xcb_connection_t *xcb_connect(const char *displayname, int *screenp)
{ {
return xcb_connect_to_display_with_auth_info(displayname, NULL, screenp); return xcb_connect_to_display_with_auth_info(displayname, NULL, screenp);