frederik
/
libxcb
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Minor performance fix: Only rearrange buffers for BIG-REQUESTs.

This commit is contained in:
Jamey Sharp 2006-02-23 14:57:46 -08:00
parent e866bed934
commit a736674943
1 changed files with 29 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

58
src/xcb_out.c
View File

@ -117,6 +117,24 @@ int XCBSendRequest(XCBConnection *c, unsigned int *request, struct iovec *vector
assert(vector != 0); assert(vector != 0);
assert(req->count > 0); assert(req->count > 0);
/* set the major opcode, and the minor opcode for extensions */
if(req->ext)
{
const XCBQueryExtensionRep *extension = XCBGetExtensionData(c, req->ext);
/* TODO: better error handling here, please! */
assert(extension && extension->present);
((CARD8 *) vector[0].iov_base)[0] = extension->major_opcode;
((CARD8 *) vector[0].iov_base)[1] = req->opcode;
/* do we need to work around the X server bug described in glx.xml? */
if(strcmp(req->ext->name, "GLX") &&
((req->opcode == 17 && ((CARD32 *) vector[0].iov_base)[0] == 0x10004) ||
req->opcode == 21))
workaround = WORKAROUND_GLX_GET_FB_CONFIGS_BUG;
}
else
((CARD8 *) vector[0].iov_base)[0] = req->opcode;
/* put together the length field, possibly using BIGREQUESTS */ /* put together the length field, possibly using BIGREQUESTS */
for(i = 0; i < req->count; ++i) for(i = 0; i < req->count; ++i)
longlen += XCB_CEIL(vector[i].iov_len) >> 2; longlen += XCB_CEIL(vector[i].iov_len) >> 2;
@ -134,39 +152,18 @@ int XCBSendRequest(XCBConnection *c, unsigned int *request, struct iovec *vector
} }
/* set the length field. */ /* set the length field. */
i = 0; ((CARD16 *) vector[0].iov_base)[1] = shortlen;
prefix[i].iov_base = vector[0].iov_base;
prefix[i].iov_len = sizeof(CARD32);
vector[0].iov_base = ((char *) vector[0].iov_base) + sizeof(CARD32);
vector[0].iov_len -= sizeof(CARD32);
((CARD16 *) prefix[i].iov_base)[1] = shortlen;
++i;
if(!shortlen) if(!shortlen)
{ {
prefix[0].iov_base = vector[0].iov_base;
prefix[0].iov_len = sizeof(CARD32);
vector[0].iov_base = ((char *) vector[0].iov_base) + sizeof(CARD32);
vector[0].iov_len -= sizeof(CARD32);
++longlen; ++longlen;
prefix[i].iov_base = &longlen; prefix[1].iov_base = &longlen;
prefix[i].iov_len = sizeof(CARD32); prefix[1].iov_len = sizeof(CARD32);
++i;
} }
/* set the major opcode, and the minor opcode for extensions */
if(req->ext)
{
const XCBQueryExtensionRep *extension = XCBGetExtensionData(c, req->ext);
/* TODO: better error handling here, please! */
assert(extension && extension->present);
((CARD8 *) prefix[0].iov_base)[0] = extension->major_opcode;
((CARD8 *) prefix[0].iov_base)[1] = req->opcode;
/* do we need to work around the X server bug described in glx.xml? */
if(strcmp(req->ext->name, "GLX") &&
((req->opcode == 17 && ((CARD32 *) vector[0].iov_base)[0] == 0x10004) ||
req->opcode == 21))
workaround = WORKAROUND_GLX_GET_FB_CONFIGS_BUG;
}
else
((CARD8 *) prefix[0].iov_base)[0] = req->opcode;
/* get a sequence number and arrange for delivery. */ /* get a sequence number and arrange for delivery. */
pthread_mutex_lock(&c->iolock); pthread_mutex_lock(&c->iolock);
if(req->isvoid && !force_sequence_wrap(c)) if(req->isvoid && !force_sequence_wrap(c))
@ -180,7 +177,10 @@ int XCBSendRequest(XCBConnection *c, unsigned int *request, struct iovec *vector
if(!req->isvoid) if(!req->isvoid)
_xcb_in_expect_reply(c, *request, workaround); _xcb_in_expect_reply(c, *request, workaround);
ret = _xcb_out_write_block(c, prefix, i); if(!shortlen)
ret = _xcb_out_write_block(c, prefix, 2);
else
ret = 1;
if(ret > 0) if(ret > 0)
ret = _xcb_out_write_block(c, vector, req->count); ret = _xcb_out_write_block(c, vector, req->count);
pthread_mutex_unlock(&c->iolock); pthread_mutex_unlock(&c->iolock);