frederik
/
xserver
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

modesetting: don't pass a big struct by value 

Fixes LGTM warning "This parameter of type drmModeModeInfo is 68 bytes -
consider passing a const pointer/reference instead."

Signed-off-by: Konstantin Kharlamov <Hi-Angel@yandex.ru>
This commit is contained in:
Konstantin Kharlamov 2019-03-24 02:22:46 +03:00 committed by Alan Coopersmith
parent b6f79815ee
commit 0011f4ad17
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
hw/xfree86/drivers/modesetting/drmmode_display.c
View File

@ -519,13 +519,13 @@ connector_add_prop(drmModeAtomicReq *req, drmmode_output_private_ptr drmmode_out
} }
static int static int
drmmode_CompareKModes(drmModeModeInfo * kmode, drmModeModeInfo * other) drmmode_CompareKModes(const drmModeModeInfo * kmode, const drmModeModeInfo * other)
{ {
return memcmp(kmode, other, sizeof(*kmode)); return memcmp(kmode, other, sizeof(*kmode));
} }
static int static int
drm_mode_ensure_blob(xf86CrtcPtr crtc, drmModeModeInfo mode_info) drm_mode_ensure_blob(xf86CrtcPtr crtc, const drmModeModeInfo* mode_info)
{ {
modesettingPtr ms = modesettingPTR(crtc->scrn); modesettingPtr ms = modesettingPTR(crtc->scrn);
drmmode_crtc_private_ptr drmmode_crtc = crtc->driver_private; drmmode_crtc_private_ptr drmmode_crtc = crtc->driver_private;
@ -533,14 +533,14 @@ drm_mode_ensure_blob(xf86CrtcPtr crtc, drmModeModeInfo mode_info)
int ret; int ret;
if (drmmode_crtc->current_mode && if (drmmode_crtc->current_mode &&
drmmode_CompareKModes(&drmmode_crtc->current_mode->mode_info, &mode_info) == 0) drmmode_CompareKModes(&drmmode_crtc->current_mode->mode_info, mode_info) == 0)
return 0; return 0;
mode = calloc(sizeof(drmmode_mode_rec), 1); mode = calloc(sizeof(drmmode_mode_rec), 1);
if (!mode) if (!mode)
return -1; return -1;
mode->mode_info = mode_info; mode->mode_info = *mode_info;
ret = drmModeCreatePropertyBlob(ms->fd, ret = drmModeCreatePropertyBlob(ms->fd,
&mode->mode_info, &mode->mode_info,
sizeof(mode->mode_info), sizeof(mode->mode_info),
@ -589,7 +589,7 @@ crtc_add_dpms_props(drmModeAtomicReq *req, xf86CrtcPtr crtc,
drmModeModeInfo kmode; drmModeModeInfo kmode;
drmmode_ConvertToKMode(crtc->scrn, &kmode, &crtc->mode); drmmode_ConvertToKMode(crtc->scrn, &kmode, &crtc->mode);
ret |= drm_mode_ensure_blob(crtc, kmode); ret |= drm_mode_ensure_blob(crtc, &kmode);
ret |= crtc_add_prop(req, drmmode_crtc, ret |= crtc_add_prop(req, drmmode_crtc,
DRMMODE_CRTC_ACTIVE, 1); DRMMODE_CRTC_ACTIVE, 1);