From 0217d0370c0b0bce66a9c09092eda8e820274e2e Mon Sep 17 00:00:00 2001 From: Peter Hutterer Date: Tue, 28 Jul 2009 14:54:30 +1000 Subject: [PATCH] record: ifdef out RecordExtensionInit and print a warning to the log. The RECORD extension is currently broken. By ifdef'ing out the content of RecordExtensionInit the extension isn't added to the server's internal list and it does not get advertised to the client. Clients can thus fail gracefully with a "extension not supported" instead of waiting forever for events that never arrive. Signed-off-by: Peter Hutterer --- record/record.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/record/record.c b/record/record.c index fd8855228..effb9263d 100644 --- a/record/record.c +++ b/record/record.c @@ -2865,6 +2865,13 @@ RecordCloseDown(ExtensionEntry *extEntry) void RecordExtensionInit(void) { + /* FIXME Record is currently broken. Dont initialize it so that clients + * that require it can bail out correctly rather than waiting for stuff + * that'll never happen */ + ErrorF("record: RECORD extension enabled at configure time.\n"); + ErrorF("record: This extension is known to be broken, disabling extension now..\n"); + ErrorF("record: http://bugs.freedesktop.org/show_bug.cgi?id=20500\n"); +#if 0 ExtensionEntry *extentry; RTContext = CreateNewResourceType(RecordDeleteContext); @@ -2887,5 +2894,6 @@ RecordExtensionInit(void) } RecordErrorBase = extentry->errorBase; +#endif } /* RecordExtensionInit */