From 0573042cddb6f9942e408687a16c6842e62a8bfa Mon Sep 17 00:00:00 2001 From: Rami Ylimaki Date: Wed, 4 Nov 2009 15:59:30 +0200 Subject: [PATCH] dix: Fixes a memory leak when a cursor resource is released. Just open and close a client that creates cursors in order to reproduce. In the problem case bits->refcnt is -1 and therefore bits->devPrivates is never released. Signed-off-by: Rami Ylimaki Signed-off-by: Keith Packard --- dix/cursor.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dix/cursor.c b/dix/cursor.c index 086d008e0..6103b15e3 100644 --- a/dix/cursor.c +++ b/dix/cursor.c @@ -86,6 +86,8 @@ FreeCursorBits(CursorBitsPtr bits) #ifdef ARGB_CURSOR xfree(bits->argb); #endif + dixFreePrivates(bits->devPrivates); + bits->devPrivates = NULL; if (bits->refcnt == 0) { GlyphSharePtr *prev, this; @@ -100,7 +102,6 @@ FreeCursorBits(CursorBitsPtr bits) CloseFont(this->font, (Font)0); xfree(this); } - dixFreePrivates(bits->devPrivates); xfree(bits); } }