From 082c0f7fb34458ebb303cf875d1d75686eca25e6 Mon Sep 17 00:00:00 2001 From: Eamon Walsh Date: Wed, 19 Sep 2007 13:59:35 -0400 Subject: [PATCH] devPrivates rework: move devPrivates field in drawable structure types to just below the DrawableRec. Wish there were a better way to do this but it has to be in the same place for all drawable types. --- include/pixmapstr.h | 2 +- include/windowstr.h | 2 +- render/picture.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/pixmapstr.h b/include/pixmapstr.h index 4162c667e..5f0e0c508 100644 --- a/include/pixmapstr.h +++ b/include/pixmapstr.h @@ -72,10 +72,10 @@ typedef struct _Drawable { typedef struct _Pixmap { DrawableRec drawable; + PrivateRec *devPrivates; int refcnt; int devKind; DevUnion devPrivate; - PrivateRec *devPrivates; #ifdef COMPOSITE short screen_x; short screen_y; diff --git a/include/windowstr.h b/include/windowstr.h index ca212ad99..4359481cd 100644 --- a/include/windowstr.h +++ b/include/windowstr.h @@ -124,6 +124,7 @@ typedef struct _WindowOpt { typedef struct _Window { DrawableRec drawable; + PrivateRec *devPrivates; WindowPtr parent; /* ancestor chain */ WindowPtr nextSib; /* next lower sibling */ WindowPtr prevSib; /* next higher sibling */ @@ -160,7 +161,6 @@ typedef struct _Window { #ifdef COMPOSITE unsigned redirectDraw:2; /* rendering is redirected from here */ #endif - PrivateRec *devPrivates; } WindowRec; /* diff --git a/render/picture.c b/render/picture.c index 660ef12ad..184edb48b 100644 --- a/render/picture.c +++ b/render/picture.c @@ -728,7 +728,7 @@ CreatePicture (Picture pid, /* security creation/labeling check */ *error = XaceHook(XACE_RESOURCE_ACCESS, client, pid, PictureType, pPicture, - RC_DRAWABLE, pDrawable, DixCreateAccess|DixSetAttrAccess); + RT_PIXMAP, pDrawable, DixCreateAccess|DixSetAttrAccess); if (*error != Success) goto out;