frederik
/
xserver
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

xwayland: Don't expose XRandR emulated modes for leaseable displays 

Leasable displays do not have any actual associated Wayland output and
are not available to regular X11 clients and left entirely to the
application who requests the lease.

As these are not actually managed by the Wayland compositor and left
entirely to the "lessee" application, the viewporter protocol required
for the XRandR emulation is not usable on such devices.

We should therefore not advertise the XRandR emulated modes for those
leasable displays.

This also solves a problem with implementations of glXGetMscRateOML()
which is used notably by Chromium/Electron. Applications using this
which will begin lagging/stuttering exponentially over
time, trying to look up a non-existent mode with 0x0 as returned by
XF86VidModeGetModeLine() with XRandR emulation for such devices.

See-also: https://github.com/labwc/labwc/issues/553
Signed-off-by: Joshua Ashton <joshua@froggi.es>
This commit is contained in:
Joshua Ashton 2022-12-29 08:05:19 +00:00 committed by Olivier Fourdan
parent 39934a656a
commit 0abb577075
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
hw/xwayland/xwayland-output.c
View File

@ -224,8 +224,8 @@ xwl_output_get_emulated_mode_for_client(struct xwl_output *xwl_output,
if (!xwl_output) if (!xwl_output)
return NULL; return NULL;
/* We don't do XRandr emulation when rootful */ /* We don't do XRandr emulation when rootful or a fake lease display */
if (!xwl_output->xwl_screen->rootless) if (!xwl_output->xwl_screen->rootless || !xwl_output->output)
return NULL; return NULL;
for (i = 0; i < XWL_CLIENT_MAX_EMULATED_MODES; i++) { for (i = 0; i < XWL_CLIENT_MAX_EMULATED_MODES; i++) {