frederik
/
xserver
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Coverity #269: Compare the requested ABI class against the ABI class of the 

module, not the module class.
This commit is contained in:
Adam Jackson 2006-03-15 16:16:24 +00:00
parent d8221a9b70
commit 116d158e85
2 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ChangeLog
View File

@ -2,6 +2,8 @@
* hw/xfree86/loader/loadmod.c: * hw/xfree86/loader/loadmod.c:
Coverity #1053: Nuke a dead variable. Coverity #1053: Nuke a dead variable.
Coverity #269: Compare the requested ABI class against the ABI class
of the module, not the module class.
* miext/cw/cw.c: * miext/cw/cw.c:
Coverity #337: Remove useless NULL check. Coverity #337: Remove useless NULL check.

2
hw/xfree86/loader/loadmod.c
View File

@ -716,7 +716,7 @@ CheckVersion(const char *module, XF86ModuleVersionInfo * data,
return FALSE; return FALSE;
} }
} else if (req->abiclass != ABI_CLASS_NONE) { } else if (req->abiclass != ABI_CLASS_NONE) {
if (!data->abiclass || strcmp(req->abiclass, data->moduleclass)) { if (!data->abiclass || strcmp(req->abiclass, data->abiclass)) {
xf86MsgVerb(X_WARNING, 2, "ABI class (%s) doesn't match the " xf86MsgVerb(X_WARNING, 2, "ABI class (%s) doesn't match the "
"required ABI class (%s)\n", "required ABI class (%s)\n",
data->abiclass ? data->abiclass : "<NONE>", data->abiclass ? data->abiclass : "<NONE>",