Xi: drop now obsolete swap procs

Lots of SProc's have become no-ops, just calling the actual Proc's,
so we can get rid of them entirely.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1639>

Xi/chgkbd.c

@@ -69,20 +69,6 @@ SOFTWARE.
  * This procedure changes the keyboard device.
  *
  */
-
-int _X_COLD
-SProcXChangeKeyboardDevice(ClientPtr client)
-{
-    return (ProcXChangeKeyboardDevice(client));
-}
-
-/***********************************************************************
- *
- * This procedure is invoked to swap the request bytes if the server and
- * client have a different byte order.
- *
- */
-
 int
 ProcXChangeKeyboardDevice(ClientPtr client)
 {

Xi/chgkbd.h

@@ -30,9 +30,6 @@ OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
 #ifndef CHGKBD_H
 #define CHGKBD_H 1
 
-int SProcXChangeKeyboardDevice(ClientPtr        /* client */
-    );
-
 int ProcXChangeKeyboardDevice(ClientPtr /* client */
     );
 

Xi/chgptr.c

@@ -65,19 +65,6 @@ SOFTWARE.
 
 #include "chgptr.h"
 
-/***********************************************************************
- *
- * This procedure is invoked to swap the request bytes if the server and
- * client have a different byte order.
- *
- */
-
-int _X_COLD
-SProcXChangePointerDevice(ClientPtr client)
-{
-    return (ProcXChangePointerDevice(client));
-}
-
 /***********************************************************************
  *
  * This procedure changes the device used as the X pointer.

Xi/chgptr.h

@@ -30,9 +30,6 @@ OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
 #ifndef CHGPTR_H
 #define CHGPTR_H 1
 
-int SProcXChangePointerDevice(ClientPtr /* client */
-    );
-
 int ProcXChangePointerDevice(ClientPtr  /* client */
     );
 

Xi/closedev.c

@@ -62,18 +62,6 @@ SOFTWARE.
 
 #include "closedev.h"
 
-/***********************************************************************
- *
- * This procedure closes an input device.
- *
- */
-
-int _X_COLD
-SProcXCloseDevice(ClientPtr client)
-{
-    return (ProcXCloseDevice(client));
-}
-
 /***********************************************************************
  *
  * Clear out event selections and passive grabs from a window for the

Xi/closedev.h

@@ -30,9 +30,6 @@ OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
 #ifndef CLOSEDEV_H
 #define CLOSEDEV_H 1
 
-int SProcXCloseDevice(ClientPtr /* client */
-    );
-
 int ProcXCloseDevice(ClientPtr  /* client */
     );
 

Xi/devbell.c

@@ -59,19 +59,6 @@ SOFTWARE.
 
 #include "devbell.h"
 
-/***********************************************************************
- *
- * This procedure is invoked to swap the request bytes if the server and
- * client have a different byte order.
- *
- */
-
-int _X_COLD
-SProcXDeviceBell(ClientPtr client)
-{
-    return (ProcXDeviceBell(client));
-}
-
 /***********************************************************************
  *
  * This procedure rings a bell on an extension device.

Xi/devbell.h

@@ -30,9 +30,6 @@ OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
 #ifndef DEVBELL_H
 #define DEVBELL_H 1
 
-int SProcXDeviceBell(ClientPtr  /* client */
-    );
-
 int ProcXDeviceBell(ClientPtr   /* client */
     );
 

Xi/extinit.c

@@ -252,19 +252,19 @@ static int (*ProcIVector[]) (ClientPtr) = {
 
 /* For swapped clients */
 static int (*SProcIVector[]) (ClientPtr) = {
-    NULL,                       /*  0 */
+        NULL,                       /*  0 */
         SProcXGetExtensionVersion,      /*  1 */
-        SProcXListInputDevices, /*  2 */
+        ProcXListInputDevices, /*  2 */
-        SProcXOpenDevice,       /*  3 */
+        ProcXOpenDevice,       /*  3 */
-        SProcXCloseDevice,      /*  4 */
+        ProcXCloseDevice,      /*  4 */
-        SProcXSetDeviceMode,    /*  5 */
+        ProcXSetDeviceMode,    /*  5 */
         SProcXSelectExtensionEvent,     /*  6 */
         SProcXGetSelectedExtensionEvents,       /*  7 */
         SProcXChangeDeviceDontPropagateList,    /*  8 */
         SProcXGetDeviceDontPropagateList,       /*  9 */
         SProcXGetDeviceMotionEvents,    /* 10 */
-        SProcXChangeKeyboardDevice,     /* 11 */
+        ProcXChangeKeyboardDevice,     /* 11 */
-        SProcXChangePointerDevice,      /* 12 */
+        ProcXChangePointerDevice,      /* 12 */
         SProcXGrabDevice,       /* 13 */
         SProcXUngrabDevice,     /* 14 */
         SProcXGrabDeviceKey,    /* 15 */
@@ -272,30 +272,30 @@ static int (*SProcIVector[]) (ClientPtr) = {
         SProcXGrabDeviceButton, /* 17 */
         SProcXUngrabDeviceButton,       /* 18 */
         SProcXAllowDeviceEvents,        /* 19 */
-        SProcXGetDeviceFocus,   /* 20 */
+        ProcXGetDeviceFocus,   /* 20 */
         SProcXSetDeviceFocus,   /* 21 */
-        SProcXGetFeedbackControl,       /* 22 */
+        ProcXGetFeedbackControl,       /* 22 */
         SProcXChangeFeedbackControl,    /* 23 */
-        SProcXGetDeviceKeyMapping,      /* 24 */
+        ProcXGetDeviceKeyMapping,      /* 24 */
         SProcXChangeDeviceKeyMapping,   /* 25 */
-        SProcXGetDeviceModifierMapping, /* 26 */
+        ProcXGetDeviceModifierMapping, /* 26 */
-        SProcXSetDeviceModifierMapping, /* 27 */
+        ProcXSetDeviceModifierMapping, /* 27 */
-        SProcXGetDeviceButtonMapping,   /* 28 */
+        ProcXGetDeviceButtonMapping,   /* 28 */
-        SProcXSetDeviceButtonMapping,   /* 29 */
+        ProcXSetDeviceButtonMapping,   /* 29 */
-        SProcXQueryDeviceState, /* 30 */
+        ProcXQueryDeviceState, /* 30 */
         SProcXSendExtensionEvent,       /* 31 */
-        SProcXDeviceBell,       /* 32 */
+        ProcXDeviceBell,       /* 32 */
-        SProcXSetDeviceValuators,       /* 33 */
+        ProcXSetDeviceValuators,       /* 33 */
         SProcXGetDeviceControl, /* 34 */
         SProcXChangeDeviceControl,      /* 35 */
-        SProcXListDeviceProperties,     /* 36 */
+        ProcXListDeviceProperties,     /* 36 */
         SProcXChangeDeviceProperty,     /* 37 */
         SProcXDeleteDeviceProperty,     /* 38 */
         SProcXGetDeviceProperty,        /* 39 */
         SProcXIQueryPointer,    /* 40 */
         SProcXIWarpPointer,     /* 41 */
         SProcXIChangeCursor,    /* 42 */
-        SProcXIChangeHierarchy, /* 43 */
+        ProcXIChangeHierarchy, /* 43 */
         SProcXISetClientPointer,        /* 44 */
         SProcXIGetClientPointer,        /* 45 */
         SProcXISelectEvents,    /* 46 */

Xi/getbmap.c

@@ -59,18 +59,6 @@ SOFTWARE.
 
 #include "getbmap.h"
 
-/***********************************************************************
- *
- * This procedure gets the button mapping for the specified device.
- *
- */
-
-int _X_COLD
-SProcXGetDeviceButtonMapping(ClientPtr client)
-{
-    return (ProcXGetDeviceButtonMapping(client));
-}
-
 /***********************************************************************
  *
  * This procedure gets the button mapping for the specified device.

Xi/getbmap.h

@@ -30,9 +30,6 @@ OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
 #ifndef GETBMAP_H
 #define GETBMAP_H 1
 
-int SProcXGetDeviceButtonMapping(ClientPtr      /* client */
-    );
-
 int ProcXGetDeviceButtonMapping(ClientPtr       /* client */
     );
 

Xi/getfctl.c

@@ -59,19 +59,6 @@ SOFTWARE.
 
 #include "getfctl.h"
 
-/***********************************************************************
- *
- * This procedure gets the control attributes for an extension device,
- * for clients on machines with a different byte ordering than the server.
- *
- */
-
-int _X_COLD
-SProcXGetFeedbackControl(ClientPtr client)
-{
-    return (ProcXGetFeedbackControl(client));
-}
-
 /***********************************************************************
  *
  * This procedure copies KbdFeedbackClass data, swapping if necessary.

Xi/getfctl.h

@@ -30,9 +30,6 @@ OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
 #ifndef GETFCTL_H
 #define GETFCTL_H 1
 
-int SProcXGetFeedbackControl(ClientPtr  /* client */
-    );
-
 int ProcXGetFeedbackControl(ClientPtr   /* client */
     );
 

Xi/getfocus.c

@@ -60,18 +60,6 @@ SOFTWARE.
 
 #include "getfocus.h"
 
-/***********************************************************************
- *
- * This procedure gets the focus for a device.
- *
- */
-
-int _X_COLD
-SProcXGetDeviceFocus(ClientPtr client)
-{
-    return (ProcXGetDeviceFocus(client));
-}
-
 /***********************************************************************
  *
  * This procedure gets the focus for a device.

Xi/getfocus.h

@@ -30,9 +30,6 @@ OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
 #ifndef GETFOCUS_H
 #define GETFOCUS_H 1
 
-int SProcXGetDeviceFocus(ClientPtr      /* client */
-    );
-
 int ProcXGetDeviceFocus(ClientPtr       /* client */
     );
 

Xi/getkmap.c

@@ -62,19 +62,6 @@ SOFTWARE.
 
 #include "getkmap.h"
 
-/***********************************************************************
- *
- * This procedure gets the key mapping for an extension device,
- * for clients on machines with a different byte ordering than the server.
- *
- */
-
-int _X_COLD
-SProcXGetDeviceKeyMapping(ClientPtr client)
-{
-    return (ProcXGetDeviceKeyMapping(client));
-}
-
 /***********************************************************************
  *
  * Get the device key mapping.

Xi/getkmap.h

@@ -30,9 +30,6 @@ OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
 #ifndef GETKMAP_H
 #define GETKMAP_H 1
 
-int SProcXGetDeviceKeyMapping(ClientPtr /* client */
-    );
-
 int ProcXGetDeviceKeyMapping(ClientPtr  /* client */
     );
 

Xi/getmmap.c

@@ -59,19 +59,6 @@ SOFTWARE.
 
 #include "getmmap.h"
 
-/***********************************************************************
- *
- * This procedure gets the modifier mapping for an extension device,
- * for clients on machines with a different byte ordering than the server.
- *
- */
-
-int _X_COLD
-SProcXGetDeviceModifierMapping(ClientPtr client)
-{
-    return (ProcXGetDeviceModifierMapping(client));
-}
-
 /***********************************************************************
  *
  * Get the device Modifier mapping.

Xi/getmmap.h

@@ -30,9 +30,6 @@ OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
 #ifndef GETMMAP_H
 #define GETMMAP_H 1
 
-int SProcXGetDeviceModifierMapping(ClientPtr    /* client */
-    );
-
 int ProcXGetDeviceModifierMapping(ClientPtr     /* client */
     );
 

Xi/grabdev.c

@@ -77,6 +77,7 @@ SProcXGrabDevice(ClientPtr client)
 {
     REQUEST(xGrabDeviceReq);
     REQUEST_AT_LEAST_SIZE(xGrabDeviceReq);
+
     swapl(&stuff->grabWindow);
     swapl(&stuff->time);
     swaps(&stuff->event_count);

Xi/listdev.c

@@ -68,18 +68,6 @@ SOFTWARE.
 #include "xkbstr.h"
 #include "listdev.h"
 
-/***********************************************************************
- *
- * This procedure lists the input devices available to the server.
- *
- */
-
-int _X_COLD
-SProcXListInputDevices(ClientPtr client)
-{
-    return (ProcXListInputDevices(client));
-}
-
 /***********************************************************************
  *
  * This procedure calculates the size of the information to be returned

Xi/listdev.h

@@ -32,9 +32,6 @@ OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
 
 #define VPC	20              /* Max # valuators per chunk */
 
-int SProcXListInputDevices(ClientPtr    /* client */
-    );
-
 int ProcXListInputDevices(ClientPtr     /* client */
     );
 

Xi/opendev.c

@@ -64,19 +64,6 @@ SOFTWARE.
 
 extern CARD8 event_base[];
 
-/***********************************************************************
- *
- * This procedure swaps the request if the server and client have different
- * byte orderings.
- *
- */
-
-int _X_COLD
-SProcXOpenDevice(ClientPtr client)
-{
-    return (ProcXOpenDevice(client));
-}
-
 /***********************************************************************
  *
  * This procedure causes the server to open an input device.

Xi/opendev.h

@@ -30,9 +30,6 @@ OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
 #ifndef OPENDEV_H
 #define OPENDEV_H 1
 
-int SProcXOpenDevice(ClientPtr  /* client */
-    );
-
 int ProcXOpenDevice(ClientPtr   /* client */
     );
 

Xi/queryst.c

@@ -47,18 +47,6 @@ from The Open Group.
 #include "xkbstr.h"
 #include "queryst.h"
 
-/***********************************************************************
- *
- * This procedure allows a client to query the state of a device.
- *
- */
-
-int _X_COLD
-SProcXQueryDeviceState(ClientPtr client)
-{
-    return (ProcXQueryDeviceState(client));
-}
-
 /***********************************************************************
  *
  * This procedure allows frozen events to be routed.

Xi/queryst.h

@@ -30,9 +30,6 @@ OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
 #ifndef QUERYST_H
 #define QUERYST_H 1
 
-int SProcXQueryDeviceState(ClientPtr    /* client */
-    );
-
 int ProcXQueryDeviceState(ClientPtr     /* client */
     );
 

Xi/setbmap.c

@@ -62,18 +62,6 @@ SOFTWARE.
 #include "exglobals.h"
 #include "setbmap.h"
 
-/***********************************************************************
- *
- * This procedure changes the button mapping.
- *
- */
-
-int _X_COLD
-SProcXSetDeviceButtonMapping(ClientPtr client)
-{
-    return (ProcXSetDeviceButtonMapping(client));
-}
-
 /***********************************************************************
  *
  * This procedure lists the input devices available to the server.

Xi/setbmap.h

@@ -30,9 +30,6 @@ OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
 #ifndef SETBMAP_H
 #define SETBMAP_H 1
 
-int SProcXSetDeviceButtonMapping(ClientPtr      /* client */
-    );
-
 int ProcXSetDeviceButtonMapping(ClientPtr       /* client */
     );
 

Xi/setdval.c

@@ -62,18 +62,6 @@ SOFTWARE.
 #include "exglobals.h"
 #include "setdval.h"
 
-/***********************************************************************
- *
- * Handle a request from a client with a different byte order.
- *
- */
-
-int _X_COLD
-SProcXSetDeviceValuators(ClientPtr client)
-{
-    return (ProcXSetDeviceValuators(client));
-}
-
 /***********************************************************************
  *
  * This procedure sets the value of valuators on an extension input device.

Xi/setdval.h

@@ -30,9 +30,6 @@ OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
 #ifndef SETDVAL_H
 #define SETDVAL_H 1
 
-int SProcXSetDeviceValuators(ClientPtr  /* client */
-    );
-
 int ProcXSetDeviceValuators(ClientPtr   /* client */
     );
 

Xi/setmmap.c

@@ -63,19 +63,6 @@ SOFTWARE.
 #include "exglobals.h"
 #include "setmmap.h"
 
-/***********************************************************************
- *
- * This procedure sets the modifier mapping for an extension device,
- * for clients on machines with a different byte ordering than the server.
- *
- */
-
-int _X_COLD
-SProcXSetDeviceModifierMapping(ClientPtr client)
-{
-    return (ProcXSetDeviceModifierMapping(client));
-}
-
 /***********************************************************************
  *
  * Set the device Modifier mapping.

Xi/setmmap.h

@@ -30,9 +30,6 @@ OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
 #ifndef SETMMAP_H
 #define SETMMAP_H 1
 
-int SProcXSetDeviceModifierMapping(ClientPtr    /* client */
-    );
-
 int ProcXSetDeviceModifierMapping(ClientPtr     /* client */
     );
 

Xi/setmode.c

@@ -62,18 +62,6 @@ SOFTWARE.
 #include "exglobals.h"
 #include "setmode.h"
 
-/***********************************************************************
- *
- * Handle a request from a client with a different byte order.
- *
- */
-
-int _X_COLD
-SProcXSetDeviceMode(ClientPtr client)
-{
-    return (ProcXSetDeviceMode(client));
-}
-
 /***********************************************************************
  *
  * This procedure sets the mode of a device.

Xi/setmode.h

@@ -30,9 +30,6 @@ OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
 #ifndef SETMODE_H
 #define SETMODE_H 1
 
-int SProcXSetDeviceMode(ClientPtr       /* client */
-    );
-
 int ProcXSetDeviceMode(ClientPtr        /* client */
     );
 

Xi/xichangehierarchy.c

@@ -128,12 +128,6 @@ XISendDeviceHierarchyEvent(int flags[MAXDEVICES])
  *
  */
 
-int _X_COLD
-SProcXIChangeHierarchy(ClientPtr client)
-{
-    return (ProcXIChangeHierarchy(client));
-}
-
 static int
 add_master(ClientPtr client, xXIAddMasterInfo * c, int flags[MAXDEVICES])
 {

Xi/xichangehierarchy.h

@@ -36,7 +36,6 @@
 #ifndef CHDEVHIER_H
 #define CHDEVHIER_H 1
 
-int SProcXIChangeHierarchy(ClientPtr /* client */ );
 int ProcXIChangeHierarchy(ClientPtr /* client */ );
 
 void XISendDeviceHierarchyEvent(int flags[MAXDEVICES]);

Xi/xiproperty.c

@@ -1013,12 +1013,6 @@ ProcXGetDeviceProperty(ClientPtr client)
     return Success;
 }
 
-int _X_COLD
-SProcXListDeviceProperties(ClientPtr client)
-{
-    return (ProcXListDeviceProperties(client));
-}
-
 int _X_COLD
 SProcXChangeDeviceProperty(ClientPtr client)
 {

Xi/xiproperty.h

@@ -36,7 +36,6 @@ int ProcXDeleteDeviceProperty(ClientPtr client);
 int ProcXGetDeviceProperty(ClientPtr client);
 
 /* request swapping */
-int SProcXListDeviceProperties(ClientPtr client);
 int SProcXChangeDeviceProperty(ClientPtr client);
 int SProcXDeleteDeviceProperty(ClientPtr client);
 int SProcXGetDeviceProperty(ClientPtr client);