frederik
/
xserver
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

glx: protect createModeFromConfig() from allocation failure 

| ../glx/glxdricommon.c: In function ‘createModeFromConfig’:
| ../glx/glxdricommon.c:142:23: warning: dereference of possibly-NULL ‘config’ [CWE-690] [-Wanalyzer-possible-null-dereference]
|   142 |     config->driConfig = driConfig;

Consumers can already handle returning NULL, so this seems the best compromise.
It will look like we don't have any modes at all. Certainly not nice, but at
least better than completely crashing the Xserver.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
This commit is contained in:
Enrico Weigelt, metux IT consult 2025-05-06 14:35:26 +02:00
parent 9ee96639d7
commit 1e055b5ddc
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
glx/glxdricommon.c
View File

@ -136,6 +136,8 @@ createModeFromConfig(const __DRIcoreExtension * core,
config = calloc(1, sizeof *config); config = calloc(1, sizeof *config);
if (!config)
return NULL;
config->driConfig = driConfig; config->driConfig = driConfig;