From 1e7b500a8e1d79b91a4e857a2da06194efe8cf69 Mon Sep 17 00:00:00 2001 From: Chase Douglas Date: Tue, 1 May 2012 10:21:11 -0700 Subject: [PATCH] Report logical button state in ProcXIQueryPointer Physical button state is usually meaningless to an X client. Signed-off-by: Chase Douglas Signed-off-by: Peter Hutterer Reviewed-by: Peter Hutterer --- Xi/xiquerypointer.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/Xi/xiquerypointer.c b/Xi/xiquerypointer.c index a2e7442e0..ba99752ef 100644 --- a/Xi/xiquerypointer.c +++ b/Xi/xiquerypointer.c @@ -132,7 +132,7 @@ ProcXIQueryPointer(ClientPtr client) } if (pDev->button) { - int i, down; + int i; rep.buttons_len = bytes_to_int32(bits_to_bytes(pDev->button->numButtons)); @@ -142,14 +142,9 @@ ProcXIQueryPointer(ClientPtr client) if (!buttons) return BadAlloc; - down = pDev->button->buttonsDown; - - for (i = 0; i < pDev->button->numButtons && down; i++) { - if (BitIsOn(pDev->button->down, i)) { - SetBit(buttons, i); - down--; - } - } + for (i = 1; i < pDev->button->numButtons; i++) + if (BitIsOn(pDev->button->down, i)) + SetBit(buttons, pDev->button->map[i]); } else rep.buttons_len = 0;