From 2263e514c4c4335c719175c989dd4e6461a15a42 Mon Sep 17 00:00:00 2001 From: "Enrico Weigelt, metux IT consult" Date: Mon, 24 Feb 2025 14:22:46 +0100 Subject: [PATCH] record: protect from memory allocation failure Signed-off-by: Enrico Weigelt, metux IT consult --- record/record.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/record/record.c b/record/record.c index 71acdea14..2f8b763bf 100644 --- a/record/record.c +++ b/record/record.c @@ -2689,7 +2689,6 @@ RecordAClientStateChange(CallbackListPtr *pcbl, void *nulldata, NewClientInfoRec *pci = (NewClientInfoRec *) calldata; int i; ClientPtr pClient = pci->client; - RecordContextPtr *ppAllContextsCopy = NULL; int numContextsCopy = 0; switch (pClient->clientState) { @@ -2714,8 +2713,9 @@ RecordAClientStateChange(CallbackListPtr *pcbl, void *nulldata, /* RecordDisableContext modifies contents of ppAllContexts. */ if (!(numContextsCopy = numContexts)) break; - ppAllContextsCopy = calloc(numContextsCopy, sizeof(RecordContextPtr)); - assert(ppAllContextsCopy); + RecordContextPtr *ppAllContextsCopy = calloc(numContextsCopy, sizeof(RecordContextPtr)); + if (!ppAllContextsCopy) + return; memcpy(ppAllContextsCopy, ppAllContexts, numContextsCopy * sizeof(RecordContextPtr));