frederik
/
xserver
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

xi: free modifiers_failed on error path. (v2) 

Pointed out by coverity.

v2: set modifies_failed to NULL at start (whot)

Signed-off-by: Dave Airlie <airlied@redhat.com>
(cherry picked from commit 51ae6126dc)
This commit is contained in:
Dave Airlie 2018-09-12 10:33:04 +10:00 committed by Olivier Fourdan
parent bdeab7863e
commit 26a83f9833
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Xi/xipassivegrab.c
View File

@ -88,7 +88,7 @@ ProcXIPassiveGrabDevice(ClientPtr client)
}; };
int i, ret = Success; int i, ret = Success;
uint32_t *modifiers; uint32_t *modifiers;
xXIGrabModifierInfo *modifiers_failed; xXIGrabModifierInfo *modifiers_failed = NULL;
GrabMask mask = { 0 }; GrabMask mask = { 0 };
GrabParameters param; GrabParameters param;
void *tmp; void *tmp;
@ -232,8 +232,8 @@ ProcXIPassiveGrabDevice(ClientPtr client)
if (rep.num_modifiers) if (rep.num_modifiers)
WriteToClient(client, rep.length * 4, modifiers_failed); WriteToClient(client, rep.length * 4, modifiers_failed);
free(modifiers_failed);
out: out:
free(modifiers_failed);
xi2mask_free(&mask.xi2mask); xi2mask_free(&mask.xi2mask);
return ret; return ret;
} }