frederik
/
xserver
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

xfixes: avoid double free if AddResource fails 

pChc is already freed through CursorFreeHideCount →
deleteCursorHideCount.

Reviewed-by: Rémi Cardona <remi@gentoo.org>
Signed-off-by: Julien Cristau <jcristau@debian.org>
This commit is contained in:
Julien Cristau 2016-03-07 23:20:34 +01:00 committed by Adam Jackson
parent 4217db89ec
commit 2be527b1d4
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
xfixes/cursor.c
View File

@ -774,10 +774,8 @@ createCursorHideCount(ClientPtr pClient, ScreenPtr pScreen)
* Create a resource for this element so it can be deleted * Create a resource for this element so it can be deleted
* when the client goes away. * when the client goes away.
*/ */
if (!AddResource(pChc->resource, CursorHideCountType, (void *) pChc)) { if (!AddResource(pChc->resource, CursorHideCountType, (void *) pChc))
free(pChc);
return BadAlloc; return BadAlloc;
}
return Success; return Success;
} }