From 2c90c3bfef8563f739a72bb645dd52b35b6ff6d5 Mon Sep 17 00:00:00 2001 From: Daniel Stone Date: Fri, 7 Apr 2006 15:57:17 +0000 Subject: [PATCH] Coverity #987: Avoid potential NULL dereference. --- ChangeLog | 3 +++ xkb/xkbEvents.c | 4 ++++ 2 files changed, 7 insertions(+) diff --git a/ChangeLog b/ChangeLog index adb25286f..25be79bc0 100644 --- a/ChangeLog +++ b/ChangeLog @@ -3,6 +3,9 @@ * hw/xfree86/utils/xorgcfg/keyboard-cfg.c: Coverity #1216: Fix double-close of file on error. + * xkb/xkbEvents.c: + Coverity #987: Avoid potential NULL dereference. + 2006-04-06 Keith Packard * fb/fbstipple.c: (fbEvenStipple): diff --git a/xkb/xkbEvents.c b/xkb/xkbEvents.c index 8305208a0..6afe7874b 100644 --- a/xkb/xkbEvents.c +++ b/xkb/xkbEvents.c @@ -214,6 +214,10 @@ int i; CARD32 changedControls; changedControls= 0; + + if (!kbd || !kbd->kbdfeed) + return 0; + if (old->enabled_ctrls!=new->enabled_ctrls) changedControls|= XkbControlsEnabledMask; if ((old->repeat_delay!=new->repeat_delay)||