From 2fbf62b2fb3dcb29551251d09aa695715bb754f4 Mon Sep 17 00:00:00 2001 From: Jason Gerecke Date: Fri, 26 May 2017 14:27:19 -0700 Subject: [PATCH] xfree86: Fix interpretation of xf86WaitForInput timeout Commit aa6717ce2 switched xf86WaitForInput from using select(2) to using poll(2). Before this change, the timeout was interpreted as being in microseconds; afterwards it is fed directly to xorg_poll which interprets it as being in milliseconds. This results in the function potentially blocking 1000x longer than intended. This commit scales down the timeout argument before passing it to xorg_poll, being careful to ensure the result is not rounded down due to integer division. Signed-off-by: Jason Gerecke Reviewed-by: Peter Hutterer Signed-off-by: Peter Hutterer --- hw/xfree86/os-support/shared/posix_tty.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/xfree86/os-support/shared/posix_tty.c b/hw/xfree86/os-support/shared/posix_tty.c index 6249a625c..a795ae19d 100644 --- a/hw/xfree86/os-support/shared/posix_tty.c +++ b/hw/xfree86/os-support/shared/posix_tty.c @@ -394,6 +394,9 @@ xf86WaitForInput(int fd, int timeout) poll_fd.fd = fd; poll_fd.events = POLLIN; + /* convert microseconds to milliseconds */ + timeout = (timeout + 999) / 1000; + if (fd >= 0) { SYSCALL(r = xserver_poll(&poll_fd, 1, timeout)); }