From 31548e3705d236d36e1b0714af7cbfeceb2f3a6e Mon Sep 17 00:00:00 2001 From: "Enrico Weigelt, metux IT consult" Date: Tue, 22 Apr 2025 21:02:37 +0200 Subject: [PATCH] fb: unexport fbValidateDrawable() Not used by any drivers, so no need to keep it exported. Signed-off-by: Enrico Weigelt, metux IT consult --- fb/fb.h | 2 -- fb/fb_priv.h | 20 ++++++++++++++++++++ fb/fbfill.c | 2 +- fb/fbpixmap.c | 2 +- fb/fbsetsp.c | 2 +- fb/fbwindow.c | 2 +- miext/rootless/rootlessWindow.c | 2 +- 7 files changed, 25 insertions(+), 7 deletions(-) create mode 100644 fb/fb_priv.h diff --git a/fb/fb.h b/fb/fb.h index 17a22ec2c..f02fdd99e 100644 --- a/fb/fb.h +++ b/fb/fb.h @@ -110,14 +110,12 @@ typedef FbBits FbStip; typedef int FbStride; #ifdef FB_DEBUG -extern _X_EXPORT void fbValidateDrawable(DrawablePtr d); extern _X_EXPORT void fbInitializeDrawable(DrawablePtr d); extern _X_EXPORT void fbSetBits(FbStip * bits, int stride, FbStip data); #define FB_HEAD_BITS (FbStip) (0xbaadf00d) #define FB_TAIL_BITS (FbStip) (0xbaddf0ad) #else -#define fbValidateDrawable(d) #define fdInitializeDrawable(d) #endif diff --git a/fb/fb_priv.h b/fb/fb_priv.h new file mode 100644 index 000000000..7ff634a62 --- /dev/null +++ b/fb/fb_priv.h @@ -0,0 +1,20 @@ +/* SPDX-License-Identifier: MIT OR X11 + * + * Copyright © 2024 Enrico Weigelt, metux IT consult + */ +#ifndef XORG_FB_PRIV_H +#define XORG_FB_PRIV_H + +#include "fb/fb.h" + +#ifdef FB_DEBUG + +void fbValidateDrawable(DrawablePtr d); + +#else + +static inline void fbValidateDrawable(DrawablePtr d) {} + +#endif /* FB_DEBUG */ + +#endif /* XORG_FB_PRIV_H */ diff --git a/fb/fbfill.c b/fb/fbfill.c index 5d08e2257..5c91c84bb 100644 --- a/fb/fbfill.c +++ b/fb/fbfill.c @@ -22,7 +22,7 @@ #include -#include "fb.h" +#include "fb/fb_priv.h" static void fbStipple(FbBits * dst, FbStride dstStride, diff --git a/fb/fbpixmap.c b/fb/fbpixmap.c index 3ed2b5680..b5dd35538 100644 --- a/fb/fbpixmap.c +++ b/fb/fbpixmap.c @@ -24,7 +24,7 @@ #include -#include "fb.h" +#include "fb/fb_priv.h" PixmapPtr fbCreatePixmap(ScreenPtr pScreen, int width, int height, int depth, diff --git a/fb/fbsetsp.c b/fb/fbsetsp.c index 0fdc17380..89f4bbffb 100644 --- a/fb/fbsetsp.c +++ b/fb/fbsetsp.c @@ -22,7 +22,7 @@ #include -#include "fb.h" +#include "fb/fb_priv.h" void fbSetSpans(DrawablePtr pDrawable, diff --git a/fb/fbwindow.c b/fb/fbwindow.c index 96e749a20..6dedf6afa 100644 --- a/fb/fbwindow.c +++ b/fb/fbwindow.c @@ -24,7 +24,7 @@ #include -#include "fb.h" +#include "fb/fb_priv.h" Bool fbCreateWindow(WindowPtr pWin) diff --git a/miext/rootless/rootlessWindow.c b/miext/rootless/rootlessWindow.c index f1cdec307..6d6c596f4 100644 --- a/miext/rootless/rootlessWindow.c +++ b/miext/rootless/rootlessWindow.c @@ -36,6 +36,7 @@ #include #include +#include "fb/fb_priv.h" #include "mi/mi_priv.h" #include "dix_priv.h" @@ -47,7 +48,6 @@ extern int darwinMainScreenX, darwinMainScreenY; extern Bool no_configure_window; #endif -#include "fb.h" #include "rootlessCommon.h" #include "rootlessWindow.h"