From 39b0c088d5054d18a083569ef33485af824bcce1 Mon Sep 17 00:00:00 2001 From: "Enrico Weigelt, metux IT consult" Date: Thu, 22 May 2025 17:29:10 +0200 Subject: [PATCH] dix: replace AtomError() by better messages Not used by any exteral drivers (and really should not be used by them), so can be replaced by more fitting error messages. Signed-off-by: Enrico Weigelt, metux IT consult --- dix/atom.c | 10 ++-------- dix/generate-atoms | 2 +- include/dix.h | 4 ---- 3 files changed, 3 insertions(+), 13 deletions(-) diff --git a/dix/atom.c b/dix/atom.c index 194b2baec..86e946bc5 100644 --- a/dix/atom.c +++ b/dix/atom.c @@ -159,12 +159,6 @@ NameForAtom(Atom atom) return node->string; } -void -AtomError(void) -{ - FatalError("initializing atoms"); -} - static void FreeAtom(NodePtr patom) { @@ -201,9 +195,9 @@ InitAtoms(void) tableLength = InitialTableSize; nodeTable = xallocarray(InitialTableSize, sizeof(NodePtr)); if (!nodeTable) - AtomError(); + FatalError("creating atom table"); nodeTable[None] = NULL; MakePredeclaredAtoms(); if (lastAtom != XA_LAST_PREDEFINED) - AtomError(); + FatalError("builtin atom number mismatch"); } diff --git a/dix/generate-atoms b/dix/generate-atoms index 780548919..48152d148 100755 --- a/dix/generate-atoms +++ b/dix/generate-atoms @@ -10,7 +10,7 @@ do_line() { local name="$1" [ "$2" != "@" ] && return 0 echo " if (MakeAtom(\"$name\", ${#name}, 1) != XA_$name)" - echo " AtomError();" + echo " FatalError(\"adding builtin atom\");" } cat > "$OUTPUT" << __END__ diff --git a/include/dix.h b/include/dix.h index f7b759d27..8981319a4 100644 --- a/include/dix.h +++ b/include/dix.h @@ -202,10 +202,6 @@ extern _X_EXPORT Bool ValidAtom(Atom /*atom */ ); extern _X_EXPORT const char *NameForAtom(Atom /*atom */ ); -extern _X_EXPORT void -AtomError(void) - _X_NORETURN; - extern _X_EXPORT void FreeAllAtoms(void);