frederik
/
xserver
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

modesetting: Check for -1 before converting to unsigned int. 

dri2.c:516:21: warning: comparison of unsigned expression < 0 is always false [-Wtautological-compare]
    if (front->name < 0)

Prevents a failure from being ignored.
This commit is contained in:
Michal Srb 2017-03-27 15:03:38 +03:00 committed by Adam Jackson
parent a9f68688f3
commit 3e3b8a40fe
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
hw/xfree86/drivers/modesetting/dri2.c
View File

@ -511,11 +511,14 @@ update_front(DrawablePtr draw, DRI2BufferPtr front)
ms_dri2_buffer_private_ptr priv = front->driverPrivate;
CARD32 size;
CARD16 pitch;
int name;
front->name = glamor_name_from_pixmap(pixmap, &pitch, &size);
if (front->name < 0)
name = glamor_name_from_pixmap(pixmap, &pitch, &size);
if (name < 0)
return FALSE;
front->name = name;
(*screen->DestroyPixmap) (priv->pixmap);
front->pitch = pixmap->devKind;
front->cpp = pixmap->drawable.bitsPerPixel / 8;