frederik
/
xserver
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

glx: Fix visual fbconfig matching with respect to swap method 

For the built in visuals, we'd typically select the "best" fbconfig
without considering the swap method. If the client then requests a
specific swap method, say GLX_SWAP_COPY_OML, it may well happen that the
first fbconfig matching requirements would have been paired with the 32-bit
compositing visual, and the client would render a potentially transparent
window.

Fix this so that we try to match fbconfigs with the same swap method to all
built-in visuals. That would guarantee that selecting a specific swap-
method would not influence the chance of getting a compositing visual.

Signed-off-by: Thomas Hellstrom <thellstrom@vmware.com>
Reviewed-by: Adam Jackson <ajax@redhat.com>
This commit is contained in:
Thomas Hellstrom 2017-09-06 16:27:54 +02:00 committed by Adam Jackson
parent 0fc26310d5
commit 4486d199bd
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
glx/glxscreens.c
View File

@ -275,6 +275,15 @@ pickFBConfig(__GLXscreen * pGlxScreen, VisualPtr visual)
if (config->visualID != 0) if (config->visualID != 0)
continue; continue;
/*
* If possible, use the same swapmethod for all built-in visual
* fbconfigs, to avoid getting the 32-bit composite visual when
* requesting, for example, a SWAP_COPY fbconfig.
*/
if (config->swapMethod == GLX_SWAP_UNDEFINED_OML)
score += 32;
if (config->swapMethod == GLX_SWAP_EXCHANGE_OML)
score += 16;
if (config->doubleBufferMode > 0) if (config->doubleBufferMode > 0)
score += 8; score += 8;
if (config->depthBits > 0) if (config->depthBits > 0)