frederik
/
xserver
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

(!1711) mi: use dixDestroyPixmap() instead of direct driver call 

Direct calls to ScreenRec->DestroyPixmap() blocks cleaning up the wrapping
jungle, so use the proper dix function instead.

See: https://gitlab.freedesktop.org/xorg/xserver/-/issues/1754

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
This commit is contained in:
Enrico Weigelt, metux IT consult 2024-09-30 17:56:15 +02:00
parent 3b395607f2
commit 47c0ca6ab3
5 changed files with 16 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
mi/miarc.c
View File

@ -1112,7 +1112,7 @@ miWideArc(DrawablePtr pDraw, GCPtr pGC, int narcs, xArc * parcs)
out:
if (fTricky) {
(*pGCTo->pScreen->DestroyPixmap) ((PixmapPtr) pDrawTo);
dixDestroyPixmap((PixmapPtr) pDrawTo, 0);
FreeScratchGC(pGCTo);
}
}

21
mi/midispcur.c
View File

@ -121,12 +121,11 @@ miDCSwitchScreenCursor(ScreenPtr pScreen, CursorPtr pCursor, PixmapPtr sourceBit
{
miDCScreenPtr pScreenPriv = dixLookupPrivate(&pScreen->devPrivates, miDCScreenKey);
if (pScreenPriv->sourceBits)
(*pScreen->DestroyPixmap)(pScreenPriv->sourceBits);
dixDestroyPixmap(pScreenPriv->sourceBits, 0);
pScreenPriv->sourceBits = sourceBits;
if (pScreenPriv->maskBits)
(*pScreen->DestroyPixmap)(pScreenPriv->maskBits);
dixDestroyPixmap(pScreenPriv->maskBits, 0);
pScreenPriv->maskBits = maskBits;
if (pScreenPriv->pPicture)
@ -205,7 +204,7 @@ miDCRealize(ScreenPtr pScreen, CursorPtr pCursor)
pGC = GetScratchGC(32, pScreen);
if (!pGC) {
(*pScreen->DestroyPixmap) (pPixmap);
dixDestroyPixmap(pPixmap, 0);
return FALSE;
}
ValidateGC(&pPixmap->drawable, pGC);
@ -216,7 +215,7 @@ miDCRealize(ScreenPtr pScreen, CursorPtr pCursor)
FreeScratchGC(pGC);
pPicture = CreatePicture(0, &pPixmap->drawable,
pFormat, 0, 0, serverClient, &error);
(*pScreen->DestroyPixmap) (pPixmap);
dixDestroyPixmap(pPixmap, 0);
if (!pPicture)
return FALSE;
@ -232,7 +231,7 @@ miDCRealize(ScreenPtr pScreen, CursorPtr pCursor)
maskBits = (*pScreen->CreatePixmap) (pScreen, pCursor->bits->width,
pCursor->bits->height, 1, 0);
if (!maskBits) {
(*pScreen->DestroyPixmap) (sourceBits);
dixDestroyPixmap(sourceBits, 0);
return FALSE;
}
@ -240,8 +239,8 @@ miDCRealize(ScreenPtr pScreen, CursorPtr pCursor)
pGC = GetScratchGC(1, pScreen);
if (!pGC) {
(*pScreen->DestroyPixmap) (sourceBits);
(*pScreen->DestroyPixmap) (maskBits);
dixDestroyPixmap(sourceBits, 0);
dixDestroyPixmap(maskBits, 0);
return FALSE;
}
@ -397,8 +396,7 @@ miDCSaveUnderCursor(DeviceIntPtr pDev, ScreenPtr pScreen,
pSave = pBuffer->pSave;
pWin = pScreen->root;
if (!pSave || pSave->drawable.width < w || pSave->drawable.height < h) {
if (pSave)
(*pScreen->DestroyPixmap) (pSave);
dixDestroyPixmap(pSave, 0);
pBuffer->pSave = pSave =
(*pScreen->CreatePixmap) (pScreen, w, h, pScreen->rootDepth, 0);
if (!pSave)
@ -515,8 +513,7 @@ miDCDeviceCleanup(DeviceIntPtr pDev, ScreenPtr pScreen)
* is freed when that root window is destroyed, so don't
* free it again here. */
if (pBuffer->pSave)
(*pScreen->DestroyPixmap) (pBuffer->pSave);
dixDestroyPixmap(pBuffer->pSave, 0);
free(pBuffer);
dixSetScreenPrivate(&pDev->devPrivates, miDCDeviceKey, pScreen,

2
mi/migc.c
View File

@ -65,7 +65,7 @@ miChangeClip(GCPtr pGC, int type, void *pvalue, int nrects)
if (type == CT_PIXMAP) {
/* convert the pixmap to a region */
pGC->clientClip = BitmapToRegion(pGC->pScreen, (PixmapPtr) pvalue);
(*pGC->pScreen->DestroyPixmap) (pvalue);
dixDestroyPixmap(pvalue, 0);
}
else if (type == CT_REGION) {
/* stuff the region in the GC */

6
mi/miglblt.c
View File

@ -120,7 +120,7 @@ miPolyGlyphBlt(DrawablePtr pDrawable, GC * pGC, int x, int y, unsigned int nglyp
pGCtmp = GetScratchGC(1, pDrawable->pScreen);
if (!pGCtmp) {
(*pDrawable->pScreen->DestroyPixmap) (pPixmap);
dixDestroyPixmap(pPixmap, 0);
return;
}
@ -134,7 +134,7 @@ miPolyGlyphBlt(DrawablePtr pDrawable, GC * pGC, int x, int y, unsigned int nglyp
nbyLine = BitmapBytePad(width);
pbits = xallocarray(height, nbyLine);
if (!pbits) {
(*pDrawable->pScreen->DestroyPixmap) (pPixmap);
dixDestroyPixmap(pPixmap, 0);
FreeScratchGC(pGCtmp);
return;
}
@ -176,7 +176,7 @@ miPolyGlyphBlt(DrawablePtr pDrawable, GC * pGC, int x, int y, unsigned int nglyp
}
x += pci->metrics.characterWidth;
}
(*pDrawable->pScreen->DestroyPixmap) (pPixmap);
dixDestroyPixmap(pPixmap, 0);
free(pbits);
FreeScratchGC(pGCtmp);
}

3
mi/miscrinit.c
View File

@ -126,7 +126,8 @@ miModifyPixmapHeader(PixmapPtr pPixmap, int width, int height, int depth,
static Bool
miCloseScreen(ScreenPtr pScreen)
{
return ((*pScreen->DestroyPixmap) ((PixmapPtr) pScreen->devPrivate));
dixDestroyPixmap((PixmapPtr) pScreen->devPrivate, 0);
return TRUE;
}
static Bool