frederik
/
xserver
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

(!1688) os: directly set log file verbosity level, instead of using LogSetParameter() 

No need for extra call to some demuxer function for nothing but setting a
simple int variable. Setting verbosity level really is nothing more than just
writing some value into a variable, so it's trivial to just to do that, instead
of having an unncessarily complex "universal setter" for that.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
This commit is contained in:
Enrico Weigelt, metux IT consult 2024-09-09 20:43:45 +02:00
parent 421eeec9c5
commit 497e981348
4 changed files with 14 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
hw/xfree86/common/xf86Init.c
View File

@ -877,7 +877,7 @@ void
xf86SetLogVerbosity(int verb)
{
xf86LogVerbose = verb;
LogSetParameter(XLOG_FILE_VERBOSITY, verb);
xorgLogFileVerbosity = verb;
}
static void

2
hw/xwin/InitOutput.c
View File

@ -543,7 +543,7 @@ OsVendorInit(void)
}
xorgLogVerbosity = g_iLogVerbose;
LogSetParameter(XLOG_FILE_VERBOSITY, g_iLogVerbose);
xorgLogFileVerbosity = g_iLogVerbose;
/* Log the version information */
if (serverGeneration == 1)

8
os/log.c
View File

@ -115,7 +115,7 @@ void (*OsVendorVErrorFProc) (const char *, va_list args) = NULL;
static int logFileFd = -1;
static Bool logSync = FALSE;
int xorgLogVerbosity = DEFAULT_LOG_VERBOSITY;
static int logFileVerbosity = DEFAULT_LOG_FILE_VERBOSITY;
int xorgLogFileVerbosity = DEFAULT_LOG_FILE_VERBOSITY;
/* Buffer to information logged before the log file is opened. */
static char *saveBuffer = NULL;
@ -322,7 +322,7 @@ LogSetParameter(LogParameter param, int value)
xorgLogVerbosity = value;
return TRUE;
case XLOG_FILE_VERBOSITY:
logFileVerbosity = value;
xorgLogFileVerbosity = value;
return TRUE;
default:
return FALSE;
@ -571,7 +571,7 @@ LogSWrite(int verb, const char *buf, size_t len, Bool end_line)
if (verb < 0 || xorgLogVerbosity >= verb)
ret = write(2, buf, len);
if (verb < 0 || logFileVerbosity >= verb) {
if (verb < 0 || xorgLogFileVerbosity >= verb) {
if (inSignalContext && logFileFd >= 0) {
ret = write(logFileFd, buf, len);
if (logSync)
@ -620,7 +620,7 @@ LogMessageTypeVerbString(MessageType type, int verb)
if (type == X_ERROR)
verb = 0;
if (xorgLogVerbosity < verb && logFileVerbosity < verb)
if (xorgLogVerbosity < verb && xorgLogFileVerbosity < verb)
return NULL;
switch (type) {

8
os/log_priv.h
View File

@ -76,4 +76,12 @@ int LogSetParameter(LogParameter param, int value);
*/
extern int xorgLogVerbosity;
/**
* @brief log file verbosity
*
* The verbosity level of logging to per-display file. All messages with
* verbosity level below this one will be written to the log file.
*/
extern int xorgLogFileVerbosity;
#endif /* __XORG_OS_LOGGING_H */