From 52e8e49defba15ae07c70ccaf7053abe4bf30296 Mon Sep 17 00:00:00 2001 From: "Enrico Weigelt, metux IT consult" Date: Mon, 30 Sep 2024 17:59:28 +0200 Subject: [PATCH] (!1711) document that ScreenRec->DestroyPixmap() shouldn't be called directly Direct calls to ScreenRec->DestroyPixmap() is fragile and blocks cleaning up the wrapping jungle, so use the proper dix function instead. While this function originally wasn't made for that purpose (and so we have an useless parameter here, and the naming isn't entirely correct), it's the best effort we have right now, without breaking existing API: it's already exported since long time, so drivers can be easily converted and still work with both new and older Xserver ABI versions. Retrospectively, this already should have been done 20 years ago. Signed-off-by: Enrico Weigelt, metux IT consult --- doc/Xserver-spec.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/Xserver-spec.xml b/doc/Xserver-spec.xml index 7736cb292..8be223e07 100644 --- a/doc/Xserver-spec.xml +++ b/doc/Xserver-spec.xml @@ -3057,6 +3057,9 @@ must deallocate the PixmapRec and all attached devPrivate blocks. If successful, it returns TRUE. See Xserver/fb/fbpixmap.c for the sample server implementation. +Consumers should never ever call that proc directly, but call dixDestroyPixmap() instead. + +
Bool