frederik
/
xserver
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ProcGrabButton: remove redundant error check. 

If dixLookupResourceByType did not return Success, it will have set the
pointer to NULL, so the second if will always be true.

Signed-off-by: Jamey Sharp <jamey@minilop.net>
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
This commit is contained in:
Jamey Sharp 2010-04-24 23:07:47 -07:00
parent 7e573b5ccd
commit 54e51de8cd
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
dix/events.c
View File

@ -5355,7 +5355,6 @@ ProcGrabButton(ClientPtr client)
rc = dixLookupResourceByType((pointer *)&cursor, stuff->cursor, RT_CURSOR, rc = dixLookupResourceByType((pointer *)&cursor, stuff->cursor, RT_CURSOR,
client, DixUseAccess); client, DixUseAccess);
if (rc != Success) if (rc != Success)
if (!cursor)
{ {
client->errorValue = stuff->cursor; client->errorValue = stuff->cursor;
return (rc == BadValue) ? BadCursor : rc; return (rc == BadValue) ? BadCursor : rc;