frederik
/
xserver
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

xwayland/present: Check allow_commits in xwl_present_flip 

We're not supposed to call wl_surface_commit while
xwl_window->allow_commits is false. Bailing results in falling back to
a copy.

Noticed by inspection while looking into an issue which turned out to be
due to something else.

Closes: https://gitlab.freedesktop.org/xorg/xserver/-/issues/1764
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1732>
This commit is contained in:
Michel Dänzer 2024-10-02 15:19:46 +02:00 committed by Marge Bot
parent 85b7765714
commit 56ba0b2a5f
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
hw/xwayland/xwayland-present.c
View File

@ -870,7 +870,7 @@ xwl_present_flip(present_vblank_ptr vblank, RegionPtr damage)
struct xwl_present_event *event = xwl_present_event_from_vblank(vblank); struct xwl_present_event *event = xwl_present_event_from_vblank(vblank);
Bool implicit_sync = TRUE; Bool implicit_sync = TRUE;
if (!xwl_window) if (!xwl_window || !xwl_window->allow_commits)
return FALSE; return FALSE;
buffer = xwl_pixmap_get_wl_buffer(pixmap); buffer = xwl_pixmap_get_wl_buffer(pixmap);