From 57e872301f5e836be2efb8f952f9c9711650b447 Mon Sep 17 00:00:00 2001 From: Adam Jackson Date: Thu, 5 Apr 2018 13:07:09 -0400 Subject: [PATCH] mi: Hush an almost certainly bogus warning MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit In file included from ../mi/miexpose.c:83: ../mi/miexpose.c: In function ‘miHandleExposures’: ../include/regionstr.h:174:22: warning: ‘expBox.y2’ may be used uninitialized in this function [-Wmaybe-uninitialized] (_pReg)->extents = *(_pBox); ~~~~~~~~~~~~~~~~~^~~~~~~~~~ ../mi/miexpose.c:139:12: note: ‘expBox.y2’ was declared here BoxRec expBox; ^~~~~~ etc. It's initialized if (extents), and then only read if (extents), but gcc doesn't seem to figure that out. Whatever, bzero it to be explicit. Signed-off-by: Adam Jackson Acked-by: Keith Packard --- mi/miexpose.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mi/miexpose.c b/mi/miexpose.c index 148d1a63b..c34530c34 100644 --- a/mi/miexpose.c +++ b/mi/miexpose.c @@ -136,7 +136,7 @@ miHandleExposures(DrawablePtr pSrcDrawable, DrawablePtr pDstDrawable, the window background */ WindowPtr pSrcWin; - BoxRec expBox; + BoxRec expBox = { 0, }; Bool extents; /* avoid work if we can */