From 5a51cb86f39a6809305c403beea54c3625e36259 Mon Sep 17 00:00:00 2001 From: Keith Packard Date: Tue, 10 Jul 2012 23:09:47 -0700 Subject: [PATCH] xfree86: When xf86CrtcCloseScreen is called, the randr CRTCs are gone The RandR CRTC structures are freed when their resource IDs are destroyed during server shut down, which is before the screen is closed. Calling back into RandR with stale pointers just segfaults the server. Signed-off-by: Keith Packard Reviewed-by: Dave Airlie Tested-by: Knut Petersen --- hw/xfree86/modes/xf86Crtc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/hw/xfree86/modes/xf86Crtc.c b/hw/xfree86/modes/xf86Crtc.c index dfce1d19f..154f684c4 100644 --- a/hw/xfree86/modes/xf86Crtc.c +++ b/hw/xfree86/modes/xf86Crtc.c @@ -734,9 +734,6 @@ xf86CrtcCloseScreen(ScreenPtr screen) for (c = 0; c < config->num_crtc; c++) { xf86CrtcPtr crtc = config->crtc[c]; - if (crtc->randr_crtc->scanout_pixmap) - RRCrtcDetachScanoutPixmap(crtc->randr_crtc); - crtc->randr_crtc = NULL; } /* detach any providers */