From 5def7f3f643bde383383e65a0a9af4043b528b2e Mon Sep 17 00:00:00 2001 From: "Enrico Weigelt, metux IT consult" Date: Tue, 6 May 2025 19:02:29 +0200 Subject: [PATCH] render: NULL-protect SetPicturePictFilter() MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Even though it shouldn't practically happen, better adding a trivial check, just in case. The check is really cheap and possibly optimized-out. | ../render/filter.c: In function ‘SetPicturePictFilter’: | ../render/filter.c:388:36: warning: dereference of possibly-NULL ‘new_params’ [CWE-690] [-Wanalyzer-possible-null-dereference] | 388 | pPicture->filter_params[i] = params[i]; | | ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~ Signed-off-by: Enrico Weigelt, metux IT consult --- render/filter.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/render/filter.c b/render/filter.c index 546998a92..bf0f845e5 100644 --- a/render/filter.c +++ b/render/filter.c @@ -387,7 +387,8 @@ SetPicturePictFilter(PicturePtr pPicture, PictFilterPtr pFilter, pPicture->filter_nparams = nparams; } for (i = 0; i < nparams; i++) - pPicture->filter_params[i] = params[i]; + if (pPicture->filter_params) + pPicture->filter_params[i] = params[i]; pPicture->filter = pFilter->id; if (pPicture->pDrawable) {