frederik
/
xserver
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

(submit/fix-char-signedness) xfree86: common: xf86pciBus: fix char signess mismatch 

On NetBSD gives warning:

In file included from /usr/include/ctype.h:100,
                 from ../hw/xfree86/common/xf86pciBus.c:35:
../hw/xfree86/common/xf86pciBus.c: In function ‘xf86ParsePciBusString’:
../hw/xfree86/common/xf86pciBus.c:286:27: warning: array subscript has type ‘char’ [-Wchar-subscripts]
  286 |             if (!isdigit(d[i])) {
      |                           ^
../hw/xfree86/common/xf86pciBus.c:293:23: warning: array subscript has type ‘char’ [-Wchar-subscripts]
  293 |         if (!isdigit(p[i])) {
      |                       ^
../hw/xfree86/common/xf86pciBus.c:307:23: warning: array subscript has type ‘char’ [-Wchar-subscripts]
  307 |         if (!isdigit(p[i])) {
      |                       ^
../hw/xfree86/common/xf86pciBus.c:320:23: warning: array subscript has type ‘char’ [-Wchar-subscripts]
  320 |         if (!isdigit(p[i])) {
      |                       ^

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
This commit is contained in:
Enrico Weigelt, metux IT consult 2024-04-02 17:14:00 +02:00
parent 3e2afb9390
commit 658962cc4c
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
hw/xfree86/common/xf86pciBus.c
View File

@ -282,14 +282,14 @@ xf86ParsePciBusString(const char *busID, int *bus, int *device, int *func)
if (d != NULL) { if (d != NULL) {
*(d++) = 0; *(d++) = 0;
for (i = 0; d[i] != 0; i++) { for (i = 0; d[i] != 0; i++) {
if (!isdigit(d[i])) { if (!isdigit((unsigned char)d[i])) {
free(s); free(s);
return FALSE; return FALSE;
} }
} }
} }
for (i = 0; p[i] != 0; i++) { for (i = 0; p[i] != 0; i++) {
if (!isdigit(p[i])) { if (!isdigit((unsigned char)p[i])) {
free(s); free(s);
return FALSE; return FALSE;
} }
@ -303,7 +303,7 @@ xf86ParsePciBusString(const char *busID, int *bus, int *device, int *func)
return FALSE; return FALSE;
} }
for (i = 0; p[i] != 0; i++) { for (i = 0; p[i] != 0; i++) {
if (!isdigit(p[i])) { if (!isdigit((unsigned char)p[i])) {
free(s); free(s);
return FALSE; return FALSE;
} }
@ -316,7 +316,7 @@ xf86ParsePciBusString(const char *busID, int *bus, int *device, int *func)
return TRUE; return TRUE;
} }
for (i = 0; p[i] != 0; i++) { for (i = 0; p[i] != 0; i++) {
if (!isdigit(p[i])) { if (!isdigit((unsigned char)p[i])) {
free(s); free(s);
return FALSE; return FALSE;
} }