frederik
/
xserver
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use C99 designated initializers in SendErrorToClient 

Let the compiler worry about 0-filling the rest of the fields,
instead of memsetting the whole struct and then going back to
overwrite some of the fields.

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: Keith Packard <keithp@keithp.com>
Tested-by: Daniel Stone <daniel@fooishbar.org>
This commit is contained in:
Alan Coopersmith 2012-07-09 19:12:43 -07:00
parent cdf5bcd420
commit 69fa5630b5
1 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
dix/dispatch.c
View File

@ -3625,14 +3625,13 @@ void
SendErrorToClient(ClientPtr client, unsigned majorCode, unsigned minorCode, SendErrorToClient(ClientPtr client, unsigned majorCode, unsigned minorCode,
XID resId, int errorCode) XID resId, int errorCode)
{ {
xError rep; xError rep = {
.type = X_Error,
memset(&rep, 0, sizeof(xError)); .errorCode = errorCode,
rep.type = X_Error; .resourceID = resId,
rep.errorCode = errorCode; .minorCode = minorCode,
rep.majorCode = majorCode; .majorCode = majorCode
rep.minorCode = minorCode; };
rep.resourceID = resId;
WriteEventsToClient(client, 1, (xEvent *) &rep); WriteEventsToClient(client, 1, (xEvent *) &rep);
} }