frederik
/
xserver
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

(!1901) os: auth: improve readability and robustness of auth proto list 

The code is easier to understand, but also more robust (eg. against struct
layout changes) if structs are initialized with explicit field names
instead of as lists.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
This commit is contained in:
Enrico Weigelt, metux IT consult 2025-03-10 10:05:53 +01:00
parent d2b662f9b0
commit 6b5ce6a11a
1 changed files with 19 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
os/auth.c
View File

@ -66,21 +66,28 @@ struct protocol {
}; };
static struct protocol protocols[] = { static struct protocol protocols[] = {
{(unsigned short) 18, "MIT-MAGIC-COOKIE-1", {
MitAddCookie, MitCheckCookie, MitResetCookie, .name_length = 18,
MitFromID, MitRemoveCookie, .name = "MIT-MAGIC-COOKIE-1",
.Add = MitAddCookie,
.Check = MitCheckCookie,
.Reset = MitResetCookie,
.FromID = MitFromID,
.Remove = MitRemoveCookie,
#ifdef XCSECURITY #ifdef XCSECURITY
MitGenerateCookie .Generate = MitGenerateCookie
#endif #endif
}, },
#ifdef HASXDMAUTH #ifdef HASXDMAUTH
{(unsigned short) 19, "XDM-AUTHORIZATION-1", {
XdmAddCookie, XdmCheckCookie, XdmResetCookie, .name_length = 19,
XdmFromID, XdmRemoveCookie, .name = "XDM-AUTHORIZATION-1",
#ifdef XCSECURITY .Add = XdmAddCookie,
NULL .Check = XdmCheckCookie,
#endif .Reset = XdmResetCookie,
}, .FromID = XdmFromID,
.Remove = XdmRemoveCookie,
},
#endif #endif
}; };