frederik
/
xserver
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix CVE-2011-4028: File disclosure vulnerability. 

use O_NOFOLLOW to open the existing lock file, so symbolic links
aren't followed, thus avoid revealing if it point to an existing
file.

Signed-off-by: Matthieu Herrb <matthieu.herrb@laas.fr>
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
This commit is contained in:
Matthieu Herrb 2011-10-17 22:26:12 +02:00
parent fb84be47db
commit 6ba44b91e3
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
os/utils.c
View File

@ -318,7 +318,7 @@ LockServer(void)
/* /*
* Read the pid from the existing file * Read the pid from the existing file
*/ */
lfd = open(LockFile, O_RDONLY); lfd = open(LockFile, O_RDONLY|O_NOFOLLOW);
if (lfd < 0) { if (lfd < 0) {
unlink(tmp); unlink(tmp);
FatalError("Can't read lock file %s\n", LockFile); FatalError("Can't read lock file %s\n", LockFile);