From 72f5874434c0c015b671c492c1318f35f1793668 Mon Sep 17 00:00:00 2001 From: Peter Hutterer Date: Tue, 13 Oct 2009 13:15:05 +1000 Subject: [PATCH] dix: extend IsPointerDevice check to valuator-only devices. A device with valuators but no keys is definitely a pointer device and needs to be attached to the VCP. Otherwise, the class copying happens on the VCK and the VCP isn't updated with the events that are to be sent through it. This addresses the trigger for #24441, not the actual issue. Jury is still out on valuator+key devices. Signed-off-by: Peter Hutterer Signed-off-by: Keith Packard --- dix/events.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/dix/events.c b/dix/events.c index 14e3900b9..aaf28b53f 100644 --- a/dix/events.c +++ b/dix/events.c @@ -345,7 +345,9 @@ DevHasCursor(DeviceIntPtr pDev) Bool IsPointerDevice(DeviceIntPtr dev) { - return (dev->type == MASTER_POINTER) || (dev->valuator && dev->button); + return (dev->type == MASTER_POINTER) || + (dev->valuator && dev->button) || + (dev->valuator && !dev->key); } /*