frederik
/
xserver
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

randr: fix unconditional byte-swap in ProcRRGetProviderInfo() 

The list of the associated provider's capabilities was always swapped
unconditionally, while it should only be in case of client having
opposite endianess.

Fixes: 426bc0a28e
Reported-By: dasha_uwu
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1977>
This commit is contained in:
Enrico Weigelt, metux IT consult 2025-05-15 10:32:52 +02:00 committed by Marge Bot
parent f0fd9f8bf4
commit 73f3c47608
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
randr/rrprovider.c
View File

@ -220,10 +220,11 @@ ProcRRGetProviderInfo (ClientPtr client)
}
if (provider->output_source) {
providers[i] = provider->output_source->id;
if (client->swapped)
swapl(&providers[i]);
prov_cap[i] = RR_Capability_SourceOutput;
if (client->swapped) {
swapl(&providers[i]);
swapl(&prov_cap[i]);
}
i++;
}
xorg_list_for_each_entry(provscreen, &pScreen->secondary_list, secondary_head) {
@ -245,7 +246,7 @@ ProcRRGetProviderInfo (ClientPtr client)
memcpy(name, provider->name, rep.nameLength);
if (client->swapped) {
swaps(&rep.sequenceNumber);
swaps(&rep.sequenceNumber);
swapl(&rep.length);
swapl(&rep.capabilities);
swaps(&rep.nCrtcs);