frederik
/
xserver
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Convert DetermineClientCmd to use strdup instead of malloc+strncpy 

*cmdname is initialized to NULL earlier in the function, so it's
okay to overwrite it with NULL if strdup fails, don't need that
extra check.

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: Jeremy Huddleston <jeremyhu@apple.com>
This commit is contained in:
Alan Coopersmith 2011-10-28 21:29:50 -07:00
parent 03ddca6f71
commit 780133f9ae
1 changed files with 1 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
os/client.c
View File

@ -149,13 +149,7 @@ void DetermineClientCmd(pid_t pid, const char **cmdname, const char **cmdargs)
cmdsize = strlen(path) + 1; cmdsize = strlen(path) + 1;
if (cmdname) if (cmdname)
{ {
char *name = malloc(cmdsize); *cmdname = strdup(path);
if (name)
{
strncpy(name, path, cmdsize);
name[cmdsize - 1] = '\0';
*cmdname = name;
}
} }
/* Construct the arguments for client process. */ /* Construct the arguments for client process. */