Revert "glx: don't leak fbconfigs"
This reverts commit d26fae246d
.
This patch free()s memory in __glXScreenDestroy which was allocated in
glxdricommon (which isn't in every DDX). That breaks abstraction and
causes a crash when XQuartz quits, because it results in freeing a pointer
that was never allocated.
The correct fix is to do this cleanup in __glXDRIscreenDestroy.
Signed-off-by: Jeremy Huddleston <jeremyhu@apple.com>
This commit is contained in:
parent
f9e6858d5c
commit
78d39b3222
|
@ -419,15 +419,6 @@ void __glXScreenInit(__GLXscreen *pGlxScreen, ScreenPtr pScreen)
|
||||||
|
|
||||||
void __glXScreenDestroy(__GLXscreen *screen)
|
void __glXScreenDestroy(__GLXscreen *screen)
|
||||||
{
|
{
|
||||||
__GLXconfig *head, *next;
|
|
||||||
|
|
||||||
head = screen->fbconfigs;
|
|
||||||
while (head) {
|
|
||||||
next = head->next;
|
|
||||||
free(head);
|
|
||||||
head = next;
|
|
||||||
}
|
|
||||||
|
|
||||||
free(screen->GLXvendor);
|
free(screen->GLXvendor);
|
||||||
free(screen->GLXextensions);
|
free(screen->GLXextensions);
|
||||||
free(screen->GLextensions);
|
free(screen->GLextensions);
|
||||||
|
|
Loading…
Reference in New Issue