frederik
/
xserver
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

posix_tty: free leak of xf86SetStrOption return value. 

Pointed out by coverity.

Signed-off-by: Dave Airlie <airlied@redhat.com>
(cherry picked from commit cad3a1a82d)
This commit is contained in:
Dave Airlie 2018-09-12 11:05:45 +10:00 committed by Olivier Fourdan
parent 66d36010a3
commit 83ef02839c
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
hw/xfree86/os-support/shared/posix_tty.c
View File

@ -188,7 +188,7 @@ xf86SetSerial(int fd, XF86OptionPtr options)
{ {
struct termios t; struct termios t;
int val; int val;
const char *s; char *s;
int baud, r; int baud, r;
if (fd < 0) if (fd < 0)
@ -264,8 +264,10 @@ xf86SetSerial(int fd, XF86OptionPtr options)
} }
else { else {
xf86Msg(X_ERROR, "Invalid Option Parity value: %s\n", s); xf86Msg(X_ERROR, "Invalid Option Parity value: %s\n", s);
free(s);
return -1; return -1;
} }
free(s);
} }
if ((val = xf86SetIntOption(options, "Vmin", -1)) != -1) { if ((val = xf86SetIntOption(options, "Vmin", -1)) != -1) {
@ -291,8 +293,10 @@ xf86SetSerial(int fd, XF86OptionPtr options)
} }
else { else {
xf86Msg(X_ERROR, "Invalid Option FlowControl value: %s\n", s); xf86Msg(X_ERROR, "Invalid Option FlowControl value: %s\n", s);
free(s);
return -1; return -1;
} }
free(s);
} }
if ((xf86SetBoolOption(options, "ClearDTR", FALSE))) { if ((xf86SetBoolOption(options, "ClearDTR", FALSE))) {