frederik
/
xserver
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Screen size bounds check in ProcRRSetCrtcConfig not masking out reflections. 

When checking how to validate the selected mode and position against the
current screen size, the test against 90/270 rotation did not mask out
reflection, so that when reflection was specified, the 90/270 test would
never succeed. This caused incorrect bounds checking and would return
an error to the user instead of rotating the screen.
This commit is contained in:
Keith Packard 2007-07-14 08:47:50 -07:00
parent 881a620b4d
commit 8773ad023e
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
randr/rrcrtc.c
View File

@ -794,7 +794,7 @@ ProcRRSetCrtcConfig (ClientPtr client)
int source_width = mode->mode.width; int source_width = mode->mode.width;
int source_height = mode->mode.height; int source_height = mode->mode.height;
if (rotation == RR_Rotate_90 || rotation == RR_Rotate_270) if ((rotation & 0xf) == RR_Rotate_90 || (rotation & 0xf) == RR_Rotate_270)
{ {
source_width = mode->mode.height; source_width = mode->mode.height;
source_height = mode->mode.width; source_height = mode->mode.width;