From 880625eef5d8b168df3e42836fa1b763c51a91b5 Mon Sep 17 00:00:00 2001 From: Peter Hutterer Date: Tue, 22 Jul 2008 14:34:28 +0930 Subject: [PATCH] xfree86: plug memory leak, free driver's private data when deleting the device. --- hw/xfree86/common/xf86Helper.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/xfree86/common/xf86Helper.c b/hw/xfree86/common/xf86Helper.c index 41181b066..fedd7a3f7 100644 --- a/hw/xfree86/common/xf86Helper.c +++ b/hw/xfree86/common/xf86Helper.c @@ -357,11 +357,11 @@ xf86DeleteInput(InputInfoPtr pInp, int flags) if (pInp->drv) pInp->drv->refCount--; - /* This should *really* be handled in drv->UnInit(dev) call instead */ -#if 0 + /* This should *really* be handled in drv->UnInit(dev) call instead, but + * if the driver forgets about it make sure we free it or at least crash + * with flying colors */ if (pInp->private) xfree(pInp->private); -#endif /* Remove the entry from the list. */ if (pInp == xf86InputDevs)