frederik
/
xserver
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

glamor: Eliminate diagonal tearing in xv 

This uses a single large triangle and a scissor to draw the video
instead of two triangles.

Signed-off-by: Keith Packard <keithp@keithp.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
This commit is contained in:
Keith Packard 2014-07-28 11:10:15 -07:00
parent 29eaa61cb2
commit 8a60d1c3f4
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
glamor/glamor_xv.c
View File

@ -336,6 +336,7 @@ glamor_xv_render(glamor_port_private *port_priv)
GL_FALSE, 2 * sizeof(float), vertices); GL_FALSE, 2 * sizeof(float), vertices);
glEnableVertexAttribArray(GLAMOR_VERTEX_POS); glEnableVertexAttribArray(GLAMOR_VERTEX_POS);
glEnable(GL_SCISSOR_TEST);
for (i = 0; i < nBox; i++) { for (i = 0; i < nBox; i++) {
float off_x = box[i].x1 - port_priv->drw_x; float off_x = box[i].x1 - port_priv->drw_x;
float off_y = box[i].y1 - port_priv->drw_y; float off_y = box[i].y1 - port_priv->drw_y;
@ -356,23 +357,25 @@ glamor_xv_render(glamor_port_private *port_priv)
glamor_set_normalize_vcoords(pixmap_priv, glamor_set_normalize_vcoords(pixmap_priv,
dst_xscale, dst_yscale, dst_xscale, dst_yscale,
dstx, dstx - dstw,
dsty, dsty,
dstx + dstw, dstx + dstw,
dsty + dsth, dsty + dsth * 2,
vertices); vertices);
glamor_set_normalize_tcoords(src_pixmap_priv[0], glamor_set_normalize_tcoords(src_pixmap_priv[0],
src_xscale[0], src_xscale[0],
src_yscale[0], src_yscale[0],
srcx, srcx - srcw,
srcy, srcy,
srcx + srcw, srcx + srcw,
srcy + srch, srcy + srch * 2,
texcoords); texcoords);
glDrawArrays(GL_TRIANGLE_FAN, 0, 4); glScissor(dstx, dsty, dstw, dsth);
glDrawArrays(GL_TRIANGLE_FAN, 0, 3);
} }
glDisable(GL_SCISSOR_TEST);
glDisableVertexAttribArray(GLAMOR_VERTEX_POS); glDisableVertexAttribArray(GLAMOR_VERTEX_POS);
glDisableVertexAttribArray(GLAMOR_VERTEX_SOURCE); glDisableVertexAttribArray(GLAMOR_VERTEX_SOURCE);