From a5769de0f5399053e9864b753fa9755220d65ae0 Mon Sep 17 00:00:00 2001 From: Jeremy Huddleston Sequoia Date: Sun, 11 Sep 2016 19:47:47 -0700 Subject: [PATCH] Xext/shm: Fix usage of F_GETFD to match standard flags = fcntl(fd, F_GETFD) is compliant. fcntl(fd, F_GETFD, &flags) is non-compliant (Linux extension?) cf: http://pubs.opengroup.org/onlinepubs/9699919799/functions/fcntl.html Signed-off-by: Jeremy Huddleston Sequoia Reviewed-by: Julien Cristau --- Xext/shm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Xext/shm.c b/Xext/shm.c index 05575385b..125000f5f 100644 --- a/Xext/shm.c +++ b/Xext/shm.c @@ -1213,7 +1213,8 @@ shm_tmpfile(void) if (fd < 0) return -1; unlink(template); - if (fcntl(fd, F_GETFD, &flags) >= 0) { + flags = fcntl(fd, F_GETFD); + if (flags != -1) { flags |= FD_CLOEXEC; (void) fcntl(fd, F_SETFD, &flags); }