frederik
/
xserver
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

(!1980) mi: NULL-protection in ‘miInitVisuals() 

NULL-Protect just against 'vid' might remain NULL.

| ../mi/micmap.c: In function ‘miInitVisuals’:
| ../mi/micmap.c:505:32: warning: dereference of NULL ‘vid’ [CWE-476] [-Wanalyzer-null-dereference]
|  505 |             visual->vid = *vid = FakeClientID(0);
|      |                           ~~~~~^~~~~~~~~~~~~~~~~

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
This commit is contained in:
Enrico Weigelt, metux IT consult 2025-05-06 14:41:27 +02:00
parent f461ccdfaf
commit a94baada20
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
mi/micmap.c
View File

@ -34,6 +34,7 @@
#include "dix/colormap_priv.h" #include "dix/colormap_priv.h"
#include "mi/mi_priv.h" #include "mi/mi_priv.h"
#include "os/bug_priv.h"
#include "os/osdep.h" #include "os/osdep.h"
#include "scrnintstr.h" #include "scrnintstr.h"
@ -504,7 +505,12 @@ miInitVisuals(VisualPtr * visualp, DepthPtr * depthp, int *nvisualp,
visual->bitsPerRGBValue = visuals->bitsPerRGB; visual->bitsPerRGBValue = visuals->bitsPerRGB;
visual->ColormapEntries = 1 << d; visual->ColormapEntries = 1 << d;
visual->nplanes = d; visual->nplanes = d;
visual->vid = *vid = FakeClientID(0); visual->vid = FakeClientID(0);
if (vid)
*vid = visual->vid;
else
BUG_WARN(vid == 0);
switch (visual->class) { switch (visual->class) {
case PseudoColor: case PseudoColor:
case GrayScale: case GrayScale: