From a9f68688f313752b1c6dfcbf6bf54f8c41fd811d Mon Sep 17 00:00:00 2001 From: Michal Srb Date: Mon, 27 Mar 2017 15:03:37 +0300 Subject: [PATCH] xfree86: Silence always true condition warning. xf86pciBus.c:1464:21: warning: comparison of constant 256 with expression of type 'uint8_t' (aka 'unsigned char') is always true [-Wtautological-constant-out-of-range-compare] if (pVideo->bus < 256) The code used to be in xf86FormatPciBusNumber and compared parameter which was int, but since b967bf2a it was inlined now it works with uint8_t. --- hw/xfree86/common/xf86pciBus.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/hw/xfree86/common/xf86pciBus.c b/hw/xfree86/common/xf86pciBus.c index cf4c27aea..0718cdcb0 100644 --- a/hw/xfree86/common/xf86pciBus.c +++ b/hw/xfree86/common/xf86pciBus.c @@ -1449,11 +1449,7 @@ xf86PciConfigureNewDev(void *busData, struct pci_device *pVideo, pVideo = (struct pci_device *) busData; - if (pVideo->bus < 256) - snprintf(busnum, sizeof(busnum), "%d", pVideo->bus); - else - snprintf(busnum, sizeof(busnum), "%d@%d", - pVideo->bus & 0x00ff, pVideo->bus >> 8); + snprintf(busnum, sizeof(busnum), "%d", pVideo->bus); XNFasprintf(&tmp, "PCI:%s:%d:%d", busnum, pVideo->dev, pVideo->func);