From acf263df81ad6813e0233033610fb44521cab1b4 Mon Sep 17 00:00:00 2001 From: Julien Cristau Date: Mon, 7 Mar 2016 23:20:30 +0100 Subject: [PATCH] modesetting: avoid double free if AddResource fails MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ms_dri2_frame_event_client_gone or ms_dri2_frame_event_drawable_gone already free the resource. Reviewed-by: Rémi Cardona Signed-off-by: Julien Cristau --- hw/xfree86/drivers/modesetting/dri2.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/xfree86/drivers/modesetting/dri2.c b/hw/xfree86/drivers/modesetting/dri2.c index 0fe420cbc..83cb3e0e7 100644 --- a/hw/xfree86/drivers/modesetting/dri2.c +++ b/hw/xfree86/drivers/modesetting/dri2.c @@ -97,10 +97,8 @@ ms_get_resource(XID id, RESTYPE type) if (resource == NULL) return NULL; - if (!AddResource(id, type, resource)) { - free(resource); + if (!AddResource(id, type, resource)) return NULL; - } resource->id = id; resource->type = type;