From b0f4bd61f0caf80f3be9a176f1f7a707bc6628d8 Mon Sep 17 00:00:00 2001 From: Keith Packard Date: Sun, 5 Dec 2010 21:53:25 -0800 Subject: [PATCH] ProcRRSetCrtcConfigs uses 'configs' without being initialized If the client sends invalid data for this request, the server will jump to 'sendReply' and call RRFreeCrtcConfigs, passing it the uninitialized 'configs' and 'num_configs' values. Signed-off-by: Keith Packard Reviewed-by: Aaron Plattner --- randr/rrcrtc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/randr/rrcrtc.c b/randr/rrcrtc.c index 97aa3d7fa..0fc818887 100644 --- a/randr/rrcrtc.c +++ b/randr/rrcrtc.c @@ -1682,9 +1682,9 @@ ProcRRSetCrtcConfigs (ClientPtr client) rrScrPrivPtr scr_priv; xRRCrtcConfig *x_configs; RRScreenConfigRec screen_config; - RRCrtcConfigPtr configs; + RRCrtcConfigPtr configs = NULL; RROutput *output_ids; - int num_configs; + int num_configs = 0; int rc, i; int extra_len; int num_output_ids;