frederik
/
xserver
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "exa/mixed: Exclude frontbuffer from deferred pixmap handling." 

This reverts commit 541b25038a.

- It turns out that the high latency was a driver problem.
- catting a large amount of text turns out to look prettier when the
  throughput is lower, but it's not worth the loss for a minor
  improvement that may not even exist on someone else's computer.

Reviewed-by: Michel Dänzer <michel@daenzer.net>
Signed-off-by: Maarten Maathuis <madman2003@gmail.com>
Signed-off-by: Keith Packard <keithp@keithp.com>
This commit is contained in:
Maarten Maathuis 2011-02-20 11:59:41 +01:00 committed by Keith Packard
parent 443d75446b
commit b4ef34d466
1 changed files with 4 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
exa/exa_migration_mixed.c
View File

@ -138,7 +138,6 @@ void
exaDamageReport_mixed(DamagePtr pDamage, RegionPtr pRegion, void *closure) exaDamageReport_mixed(DamagePtr pDamage, RegionPtr pRegion, void *closure)
{ {
PixmapPtr pPixmap = closure; PixmapPtr pPixmap = closure;
ScreenPtr pScreen = pPixmap->drawable.pScreen;
ExaPixmapPriv(pPixmap); ExaPixmapPriv(pPixmap);
/* Move back results of software rendering on system memory copy of mixed driver /* Move back results of software rendering on system memory copy of mixed driver
@ -150,19 +149,11 @@ exaDamageReport_mixed(DamagePtr pDamage, RegionPtr pRegion, void *closure)
if (!pExaPixmap->use_gpu_copy && exaPixmapHasGpuCopy(pPixmap)) { if (!pExaPixmap->use_gpu_copy && exaPixmapHasGpuCopy(pPixmap)) {
ExaScreenPriv(pPixmap->drawable.pScreen); ExaScreenPriv(pPixmap->drawable.pScreen);
/* Front buffer: Don't wait for the block handler to copy back the data.
* This avoids annoying latency if you encounter a lot of software rendering.
*/
if (pPixmap == pScreen->GetScreenPixmap(pScreen))
exaMoveInPixmap_mixed(pPixmap);
else {
if (pExaScr->deferred_mixed_pixmap && if (pExaScr->deferred_mixed_pixmap &&
pExaScr->deferred_mixed_pixmap != pPixmap) pExaScr->deferred_mixed_pixmap != pPixmap)
exaMoveInPixmap_mixed(pExaScr->deferred_mixed_pixmap); exaMoveInPixmap_mixed(pExaScr->deferred_mixed_pixmap);
pExaScr->deferred_mixed_pixmap = pPixmap; pExaScr->deferred_mixed_pixmap = pPixmap;
} }
}
} }
/* With mixed pixmaps, if we fail to get direct access to the driver pixmap, we /* With mixed pixmaps, if we fail to get direct access to the driver pixmap, we