From b7c59f2dacd1385412a7ddb0179744d34b5c5b70 Mon Sep 17 00:00:00 2001 From: "Enrico Weigelt, metux IT consult" Date: Tue, 2 Apr 2024 17:32:56 +0200 Subject: [PATCH] (submit/fix-char-signedness) xkb: xkbInit: fix char signess mismatch MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On NetBSD gives warning: ../xkb/xkbInit.c: In function ‘XkbProcessArguments’: ../xkb/xkbInit.c:778:57: warning: array subscript has type ‘char’ [-Wchar-subscripts] 778 | if (((i + 1) < argc) && (isdigit(argv[i + 1][0]))) { | ^ ../xkb/xkbInit.c:782:61: warning: array subscript has type ‘char’ [-Wchar-subscripts] 782 | if (((i + 1) < argc) && (isdigit(argv[i + 1][0]))) { | ^ ../xkb/xkbInit.c:792:61: warning: array subscript has type ‘char’ [-Wchar-subscripts] 792 | if (((i + 1) < argc) && (isdigit(argv[i + 1][0]))) { | ^ ../xkb/xkbInit.c:799:61: warning: array subscript has type ‘char’ [-Wchar-subscripts] 799 | if (((i + 1) < argc) && (isdigit(argv[i + 1][0]))) { | ^ --- xkb/xkbInit.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/xkb/xkbInit.c b/xkb/xkbInit.c index 4c12c2480..2819935eb 100644 --- a/xkb/xkbInit.c +++ b/xkb/xkbInit.c @@ -769,11 +769,11 @@ XkbProcessArguments(int argc, char *argv[], int i) else { XkbWantAccessX = 1; - if (((i + 1) < argc) && (isdigit(argv[i + 1][0]))) { + if (((i + 1) < argc) && (isdigit((unsigned char)argv[i + 1][0]))) { XkbDfltAccessXTimeout = atoi(argv[++i]); j++; - if (((i + 1) < argc) && (isdigit(argv[i + 1][0]))) { + if (((i + 1) < argc) && (isdigit((unsigned char)argv[i + 1][0]))) { /* * presumption that the reasonably useful range of * values fits in 0..MAXINT since SunOS 4 doesn't @@ -783,14 +783,14 @@ XkbProcessArguments(int argc, char *argv[], int i) strtol(argv[++i], NULL, 16); j++; } - if (((i + 1) < argc) && (isdigit(argv[i + 1][0]))) { + if (((i + 1) < argc) && (isdigit((unsigned char)argv[i + 1][0]))) { if (argv[++i][0] == '1') XkbDfltAccessXFeedback = XkbAccessXFeedbackMask; else XkbDfltAccessXFeedback = 0; j++; } - if (((i + 1) < argc) && (isdigit(argv[i + 1][0]))) { + if (((i + 1) < argc) && (isdigit((unsigned char)argv[i + 1][0]))) { XkbDfltAccessXOptions = (unsigned short) strtol(argv[++i], NULL, 16); j++;