From bd7d5255ce4865b684f7d8bcf80ba9872a1af22d Mon Sep 17 00:00:00 2001
From: Peter Hutterer <peter@cs.unisa.edu.au>
Date: Tue, 16 Oct 2007 11:18:31 +0930
Subject: [PATCH] dix: add AttachDevice, needed to attach a slave device to a
 master device.

For now, we don't allow attaching slaves to other slaves, and we don't allow
pairing slaves with other slaves.
Pairing is for master keyboard->master pointer only.
Attaching is for slave device->master device only.
---
 dix/devices.c   | 47 ++++++++++++++++++++++++++++++++++++++---------
 include/input.h |  3 +++
 2 files changed, 41 insertions(+), 9 deletions(-)

diff --git a/dix/devices.c b/dix/devices.c
index 9e9fca3e3..c41fa0c69 100644
--- a/dix/devices.c
+++ b/dix/devices.c
@@ -540,11 +540,11 @@ InitAndStartDevices(WindowPtr root)
 	ActivateDevice(dev);
     }
 
-    if (!inputInfo.keyboard) {
+    if (!inputInfo.keyboard) { /* In theory, this cannot happen */
 	ErrorF("[dix] No core keyboard\n");
 	return BadImplementation;
     }
-    if (!inputInfo.pointer) {
+    if (!inputInfo.pointer) { /* In theory, this cannot happen */
 	ErrorF("[dix] No core pointer\n");
 	return BadImplementation;
     }
@@ -555,10 +555,6 @@ InitAndStartDevices(WindowPtr root)
     if (inputInfo.pointer->inited && inputInfo.pointer->startup)
         EnableDevice(inputInfo.pointer);
 
-    /* Remove VCP and VCK from device list */
-    inputInfo.devices = NULL;
-    inputInfo.keyboard->next = inputInfo.pointer->next = NULL;
-
     /* enable real devices */
     for (dev = inputInfo.off_devices; dev; dev = next)
     {
@@ -569,17 +565,20 @@ InitAndStartDevices(WindowPtr root)
     }
 
     /* All of the devices are started up now. Pair VCK with VCP, then
-     * pair each real keyboard with a real pointer. 
+     * attach each device to the initial master.
      */ 
     PairDevices(NULL, inputInfo.pointer, inputInfo.keyboard);
 
     for (dev = inputInfo.devices; dev; dev = dev->next)
     {
         if (!DevHasCursor(dev))
-            PairDevices(NULL, GuessFreePointerDevice(), dev);
+            AttachDevice(NULL, dev, inputInfo.keyboard);
         else
+        {
+            AttachDevice(NULL, dev, inputInfo.pointer);
             /* enter/leave counter on root window */
             ((FocusSemaphoresPtr)root->devPrivates[FocusPrivatesIndex].ptr)->enterleave++;
+        }
     }
 
     return Success;
@@ -2195,7 +2194,7 @@ ProcQueryKeymap(ClientPtr client)
 }
 
 /* Pair the keyboard to the pointer device. Keyboard events will follow the
- * pointer sprite. 
+ * pointer sprite. Only applicable for master devices. 
  * If the client is set, the request to pair comes from some client. In this
  * case, we need to check for access. If the client is NULL, it's from an
  * internal automatic pairing, we must always permit this.
@@ -2206,6 +2205,10 @@ PairDevices(ClientPtr client, DeviceIntPtr ptr, DeviceIntPtr kbd)
     if (!ptr)
         return BadDevice;
 
+    /* Don't allow pairing for slave devices */
+    if (ptr->master || kbd->master)
+        return BadDevice;
+
     if (!pairingClient)
         RegisterPairingClient(client);
     else if (client && pairingClient != client)
@@ -2223,6 +2226,32 @@ PairDevices(ClientPtr client, DeviceIntPtr ptr, DeviceIntPtr kbd)
     return Success;
 }
 
+/**
+ * Attach device 'dev' to device 'master'.
+ * Client is set to the client that issued the request, or NULL if it comes
+ * from some internal automatic pairing.
+ *
+ * We don't allow multi-layer hierarchies right now. You can't attach a slave
+ * to another slave. 
+ */
+int
+AttachDevice(ClientPtr client, DeviceIntPtr dev, DeviceIntPtr master)
+{
+    if (!dev || !master)
+        return BadDevice;
+
+    if (master->master) /* can't attach to slave device */
+        return BadDevice;
+
+    if (!pairingClient)
+        RegisterPairingClient(client);
+    else if (client && pairingClient != client)
+        return BadAccess;
+
+    dev->master = master;
+
+    return Success;
+}
 /* Return the pointer that is paired with the given keyboard. If no pointer is
  * paired, return the virtual core pointer 
  */ 
diff --git a/include/input.h b/include/input.h
index d86a969c8..1ef36b8d8 100644
--- a/include/input.h
+++ b/include/input.h
@@ -465,6 +465,9 @@ extern DeviceIntPtr LookupDeviceIntRec(
 extern int PairDevices(ClientPtr client, 
                        DeviceIntPtr pointer, 
                        DeviceIntPtr keyboard);
+extern int AttachDevice(ClientPtr client,
+                        DeviceIntPtr slave,
+                        DeviceIntPtr master);
 
 extern DeviceIntPtr GetPairedPointer(DeviceIntPtr kbd);
 extern DeviceIntPtr GetPairedKeyboard(DeviceIntPtr ptr);