diff --git a/ChangeLog b/ChangeLog index 12e39210f..ca93ef3a1 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,11 @@ +2005-12-30 Eric Anholt + + * hw/xgl/xglsync.c: (xglSyncBits), (xglSyncSurface): + Initialize the fourcc value in stack-allocated glitz_pixel_format_t + structures. Greatly reduces the number of uninitialized-value accesses + during Xgl startup according to valgrind. Allocating and filling these + in by hand on the stack seems very shady to me. + 2005-12-30 Eric Anholt * configure.ac: diff --git a/hw/xgl/xglsync.c b/hw/xgl/xglsync.c index 0fa3aa05a..d15733c6b 100644 --- a/hw/xgl/xglsync.c +++ b/hw/xgl/xglsync.c @@ -173,6 +173,7 @@ xglSyncBits (DrawablePtr pDrawable, pBox = REGION_RECTS (®ion); nBox = REGION_NUM_RECTS (®ion); + format.fourcc = GLITZ_FOURCC_RGB; format.masks = pPixmapPriv->pPixel->masks; while (nBox--) @@ -250,6 +251,7 @@ xglSyncSurface (DrawablePtr pDrawable) pBox = REGION_RECTS (pRegion); pExt = REGION_EXTENTS (pDrawable->pScreen, pRegion); + format.fourcc = GLITZ_FOURCC_RGB; format.masks = pPixmapPriv->pPixel->masks; format.xoffset = pExt->x1;