From c8e5fc30575a309c25970fc68b9184c07bb74df4 Mon Sep 17 00:00:00 2001 From: Simon Thum Date: Tue, 5 Apr 2016 14:29:47 +0200 Subject: [PATCH] dix/ptraccel: Fix memory leak in InitPredictableAccelerationScheme This was quite unlikely except in situations where a proper startup would have been impossible anyway, but since automated checks don't grade likelyhood just fix it. Detected by Jeremy Huddleston's clang checks. Signed-off-by: Simon Thum Reviewed-by: Peter Hutterer Signed-off-by: Peter Hutterer --- dix/ptrveloc.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/dix/ptrveloc.c b/dix/ptrveloc.c index e75300a17..050c12a0c 100644 --- a/dix/ptrveloc.c +++ b/dix/ptrveloc.c @@ -134,13 +134,19 @@ InitPredictableAccelerationScheme(DeviceIntPtr dev, scheme = *protoScheme; vel = calloc(1, sizeof(DeviceVelocityRec)); schemeData = calloc(1, sizeof(PredictableAccelSchemeRec)); - if (!vel || !schemeData) + if (!vel || !schemeData) { + free(vel); + free(schemeData); return FALSE; + } InitVelocityData(vel); schemeData->vel = vel; scheme.accelData = schemeData; - if (!InitializePredictableAccelerationProperties(dev, vel, schemeData)) + if (!InitializePredictableAccelerationProperties(dev, vel, schemeData)) { + free(vel); + free(schemeData); return FALSE; + } /* all fine, assign scheme to device */ dev->valuator->accelScheme = scheme; return TRUE;